Hi Timo, Sergey, First, thanks for the +1s / support.
My understanding is that the planner will re-order columns in this sequence: physical, computed, and then metadata. Given that, I think CTAS should be fine... That said, while exploring around CTAS, I did see PushFilterInCalcIntoTableSourceRule, and it is unclear if that rule needs to include support here. Let me know if you know of any ways to trigger that. It looks like it is streaming only. Anyhow, we are heading into things we can discuss on the PR. If there's no other feedback, I'll call for the vote tomorrow / Thursday. Cheers, Jim On Wed, Apr 15, 2026 at 8:01 AM Timo Walther <[email protected]> wrote: > CTAS are translated into a CREATE TABLE and INSERT INTO eventually, > those. Metadata filter push-down covers the scan part, so this should > not be a concern. > > Cheers, > Timo > > On 15.04.26 08:48, Sergey Nuyanzin wrote: > > +1 for the proposal > > > > one thing to note: if I remember correctly during CREATE TABLE AS > > columns might be reordered > > in order to be on the safe side, can we also have a couple of tests > > for CREATE TABLE AS then (for now I don't see any)? > > > > On Mon, Apr 13, 2026 at 4:53 PM Timo Walther <[email protected]> wrote: > >> > >> Hi Jim, > >> > >> thanks for spotting this and coming up with a solution. I agree that the > >> combination of different ability interfaces was not well tested. The > >> interface looks clean to me and fits into the existing ones. > >> > >> +1 for this proposal. > >> > >> Thanks, > >> Timo > >> > >> On 10.04.26 21:40, Jim Hughes via dev wrote: > >>> Hi all, > >>> > >>> I'd like to open a discussion on FLIP-574: Metadata Filter Push-Down > for > >>> Table Sources. See > >>> > https://cwiki.apache.org/confluence/display/FLINK/FLIP-574+Metadata+Filter+Push-Down+for+Table+Sources > >>> > >>> Predicates on metadata columns (e.g., Kafka offset, timestamp, > partition) > >>> cannot be pushed through the existing SupportsFilterPushDown path > because > >>> FilterPushDownSpec's serialized indices break during compiled plan > >>> restoration when ProjectPushDownSpec narrows the row type. > >>> > >>> This FLIP adds a dedicated metadata filter push-down path via new > default > >>> methods on SupportsReadingMetadata, with a separate > >>> MetadataFilterPushDownSpec that snapshots the row type at optimization > >>> time. Existing sources are unaffected (opt-in design). > >>> > >>> A PR is available at https://github.com/apache/flink/pull/27913 to > show how > >>> this would work. > >>> > >>> Looking forward to your feedback. > >>> > >>> Thanks in advance, > >>> > >>> Jim > >>> > >> > > > > > >
