+1. Let's keep the configs consistent. Thanks,
Jiangjie (Becket) Qin On Fri, Jun 20, 2025 at 5:08 PM Gustavo de Morais <gustavopg...@gmail.com> wrote: > +1(non-binding). > > Kind regards, > Gustavo > > On Fri, 20 Jun 2025 at 08:13, Ron Liu <ron9....@gmail.com> wrote: > > > +1, make sense. > > > > Best, > > Ron > > > > Hao Li <h...@confluent.io.invalid> 于2025年6月19日周四 13:22写道： > > > > > Hi all, > > > > > > As part of the discussion in AsyncTableFunction PR [1], it's suggested > to > > > change the config name from `table.exec.async-table.buffer-capacity` to > > > `table.exec.async-table.max-concurrent-operations`. I think the change > > > makes sense and to make the model async config name > > > consistent with async table, I'm proposing to change the proposed > config > > in > > > this FLIP-525 from `table.exec.async-ml-predict.buffer-capacity` to > > > `table.exec.async-ml-predict.max-concurrent-operations`. > > > > > > What do people think? If there's no objection, I'll go ahead and make > the > > > change in FLIP and code since the feature isn't released yet. > > > > > > Thanks, > > > Hao > > > > > > [1] https://github.com/apache/flink/pull/26567/files#r2144129856 > > > > > > On Mon, May 12, 2025 at 9:47 AM Hao Li <h...@confluent.io> wrote: > > > > > > > Hi all, > > > > > > > > I was reminded that 72 hours means business days. So the vote is > still > > > > open :) Sorry about the confusion. > > > > > > > > Thanks, > > > > Hao > > > > > > > > On Mon, May 12, 2025 at 1:18 AM Sergey Nuyanzin <snuyan...@gmail.com > > > > > > wrote: > > > > > > > >> +1 (binding) > > > >> > > > >> On Mon, May 12, 2025 at 9:55 AM Piotr Nowojski < > pnowoj...@apache.org> > > > >> wrote: > > > >> > > > > >> > +1 (binding) > > > >> > > > > >> > Best, > > > >> > Piotrek > > > >> > > > > >> > niedz., 11 maj 2025 o 18:14 Hao Li <h...@confluent.io.invalid> > > > >> napisał(a): > > > >> > > > > >> > > Hi Dev, > > > >> > > > > > >> > > Thanks all for voting. I'm closing the vote and the result will > be > > > >> posted > > > >> > > in a separate email. > > > >> > > > > > >> > > Thanks, > > > >> > > Hao > > > >> > > > > > >> > > On Fri, May 9, 2025 at 12:43 AM Martijn Visser < > > > >> martijnvis...@apache.org> > > > >> > > wrote: > > > >> > > > > > >> > > > +1 (binding) > > > >> > > > > > > >> > > > On Fri, May 9, 2025 at 9:27 AM Yunfeng Zhou < > > > >> flink.zhouyunf...@gmail.com > > > >> > > > > > > >> > > > wrote: > > > >> > > > > > > >> > > > > +1(non-binding) > > > >> > > > > > > > >> > > > > Best, > > > >> > > > > Yunfeng > > > >> > > > > > > > >> > > > > > 2025年5月9日 00:01，Hao Li <h...@confluent.io.INVALID> 写道： > > > >> > > > > > > > > >> > > > > > Hi everyone, > > > >> > > > > > > > > >> > > > > > I'd like to start a vote on FLIP-525: Model ML_PREDICT, > > > >> ML_EVALUATE > > > >> > > > > > Implementation Design [1], which has been discussed in > this > > > >> thread > > > >> > > [2]. > > > >> > > > > > > > > >> > > > > > The vote will be open for at least 72 hours unless there > is > > an > > > >> > > > objection > > > >> > > > > > or not enough votes. > > > >> > > > > > > > > >> > > > > > Thanks, > > > >> > > > > > Hao > > > >> > > > > > > > > >> > > > > > [1] > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-525%3A+Model+ML_PREDICT%2C+ML_EVALUATE+Implementation+Design > > > >> > > > > > [2] > > > >> https://lists.apache.org/thread/880cxnw9ygsjl3x5w0kxrh4x5fw6mp4x > > > >> > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > >> > > > >> > > > >> -- > > > >> Best regards, > > > >> Sergey > > > >> > > > > > > > > > >
