Hi Timo, > I don't fully understand why we need BuiltinFunctionQueryOperation and BuiltInCallExpression
The main reason is that `CallExpression` and `FunctionQueryOperation` seem to be for `FunctionDefinition` instead of `SqlFunction`. So I want to make new classes just for `SqlFunction`. But of course we can add more information to those existing classes to cater for `SqlFunction` as well. I agree these are implementation details. I'll remove these function definitions and we can discuss them in PR. Thanks, Hao On Mon, May 12, 2025 at 7:58 AM Timo Walther <twal...@apache.org> wrote: > One last thing to mention: I don't fully understand why we need > BuiltinFunctionQueryOperation and BuiltInCallExpression. But we can > discuss this in the PR as this is not public API. In any case, we should > make sure to keep the changes to visitors and concepts in Table API > small. In the end, most stuff should be reusable from the PTF work. > > Cheers, > Timo > > > On 12.05.25 16:46, Timo Walther wrote: > > +1 to continue to voting. > > > > Thanks, > > Timo > > > > On 11.05.25 18:47, Hao Li wrote: > >> Hi all, > >> > >> If there are no more discussions. I will start voting tomorrow. > >> > >> Thanks, > >> Hao > >> > >> On Thu, May 8, 2025 at 10:38 AM Hao Li <h...@confluent.io> wrote: > >> > >>> Hi Ron, > >>> > >>>> whether the predict or evaluate introduced in this FLIP can be > >>> serialized to SQL? > >>> > >>> Yes. It can be serialized to SQL. We just need to provide serialization > >>> function in `ModelReferenceExpression` and `ModelSourceQueryOperation`. > >>> > >>> Thanks, > >>> Hao > >>> > >>> > >>> On Thu, May 8, 2025 at 12:09 AM Ron Liu <ron9....@gmail.com> wrote: > >>>> > >>>> Hi, Hao > >>>> > >>>> +1 for the proposal. > >>>> > >>>> Due to [1][2] having supported serialize table API to SQL, so I've one > >>>> question: whether the predict or evaluate introduced in this FLIP > >>>> can be > >>>> serialized to SQL? > >>>> > >>>> [1] > >>>> > >>> https://cwiki.apache.org/confluence/display/FLINK/ > >>> FLIP-393%3A+Make+QueryOperations+SQL+serializable > >>>> [2] > >>>> > >>> https://cwiki.apache.org/confluence/display/FLINK/ > >>> FLIP-502%3A+QueryOperation+SQL+Serialization+customization > >>>> > >>>> > >>>> Kindly reminder: The FLIP link [1] is error in your first email. > >>>> > >>>> Best, > >>>> Ron > >>>> > >>>> Yash Anand <yan...@confluent.io.invalid> 于2025年5月5日周一 23:24写道： > >>>> > >>>>> Hi, Hao. > >>>>> > >>>>> +1 for the proposal. > >>>>> > >>>>> Thanks > >>>>> Yas > >>>>> > >>>>> On Mon, May 5, 2025 at 4:17 AM Piotr Nowojski <pnowoj...@apache.org> > >>>>> wrote: > >>>>> > >>>>>> Hi, > >>>>>> > >>>>>> sounds like a valuable addition! > >>>>>> > >>>>>> Best, > >>>>>> Piotrek > >>>>>> > >>>>>> wt., 29 kwi 2025 o 03:57 Shengkai Fang <fskm...@gmail.com> > >>> napisał(a): > >>>>>> > >>>>>>> Hi, Hao. > >>>>>>> > >>>>>>> +1 for the proposal. > >>>>>>> > >>>>>>> Best, > >>>>>>> Shengkai > >>>>>>> > >>>>>>> Hao Li <h...@confluent.io.invalid> 于2025年4月29日周二 07:27写道： > >>>>>>> > >>>>>>>> Hi All, > >>>>>>>> > >>>>>>>> I would like to start a discussion about FLIP-526 [1]: Model > >>>>>> ML_PREDICT, > >>>>>>>> ML_EVALUATE Table API. > >>>>>>>> > >>>>>>>> This FLIP is a follow up of FLIP-507 [2] to propose the table > >>> api for > >>>>>>> model > >>>>>>>> related functions. This FLIP is also closely related to FLIP-525 > >>> [3] > >>>>>>> which > >>>>>>>> is the proposal for model related function implementation design. > >>>>>>>> > >>>>>>>> For more details, see FLIP-526 [1]. Looking forward to your > >>> feedback. > >>>>>>>> > >>>>>>>> Thanks, > >>>>>>>> Hao > >>>>>>>> > >>>>>>>> > >>>>>>>> [1] > >>>>>>>> > >>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> https://cwiki.apache.org/confluence/display/FLINK/ > >>> FLIP-525%3A+Model+ML_PREDICT%2C+ML_EVALUATE+Implementation+Design > >>>>>>>> [2] > >>>>>>>> > >>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> https://cwiki.apache.org/confluence/display/FLINK/ > >>> FLIP-507%3A+Add+Model+DDL+methods+in+TABLE+API > >>>>>>>> [3] > >>>>>>>> > >>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> https://cwiki.apache.org/confluence/display/FLINK/ > >>> FLIP-525%3A+Model+ML_PREDICT%2C+ML_EVALUATE+Implementation+Design > >>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > > > >
