+1 (binding) - verified signatures - verified hashsums - checked Github release tag - checked release notes - checked compiled Java version is 55.0 (Java SE 11) - reviewed the web PR
Best, Leonard > 2025 4月 11 19:00,Xiqian YU <kono....@outlook.com> 写道: > > +1 (non-binding) > > Checklist: > > - Tarball sha512 checksum and gig signatures are valid > - Compiled code & ran unit test cases successfully with JDK 11 and 17 > - Confirmed jars were built with JDK 11.0.23 and Apache Maven 3.8.6, bytecode > version is 55.0 > - Reviewed JIRA release note & flink-web PR > > Best Regards, > Xiqian > >> 2025年4月11日 18:18,Yanquan Lv <decq12y...@gmail.com> 写道: >> >> +1 (non-binding) >> >> I checked: >> - Review JIRA release notes >> - Verify hashes and verify signatures >> - Build success from source with JDK17 & maven3.8.6 >> - Source code artifacts matching the current release >> - Read the announcement blog and LGTM >> - Run a datagen to elasticsearch7 test with Flink 2.0 cluster and it worked >> as expected >> >> weijie guo <guoweijieres...@gmail.com> 于2025年4月11日周五 14:37写道: >> >>> Hi everyone, >>> >>> >>> >>> >>> Please review and vote on the release candidate #2 for v4.0.0, as follows: >>> >>> >>> [ ] +1, Approve the release >>> >>> >>> [ ] -1, Do not approve the release (please provide specific comments) >>> >>> >>> >>> >>> This release is mainly for flink 2.0. >>> >>> >>> >>> >>> The complete staging area is available for your review, which includes: >>> >>> >>> * JIRA release notes [1], >>> >>> >>> * the official Apache source release to be deployed to dist.apache.org >>> [2], >>> >>> >>> which are signed with the key with fingerprint >>> 8D56AE6E7082699A4870750EA4E8C4C05EE6861F [3], >>> >>> >>> * all artifacts to be deployed to the Maven Central Repository [4], >>> >>> >>> * source code tag v4.0.0-rc2 [5], >>> >>> >>> * website pull request listing the new release [6]. >>> >>> >>> * CI build of tag [7]. >>> >>> >>> >>> >>> The vote will be open for at least 72 hours. It is adopted by majority >>> >>> >>> approval, with at least 3 PMC affirmative votes. >>> >>> >>> >>> >>> Thanks, >>> >>> >>> Weijie >>> >>> >>> >>> [1] >>> >>> >>> >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12355810 >>> >>> >>> [2] >>> >>> >>> >>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-elasticsearch-4.0.0-rc2/ >>> >>> >>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >>> >>> >>> [4] >>> https://repository.apache.org/content/repositories/orgapacheflink-1801/ >>> >>> >>> [5] >>> >>> >>> >>> https://github.com/apache/flink-connector-elasticsearch/releases/tag/v4.0.0-rc2 >>> >>> >>> [6] https://github.com/apache/flink-web/pull/786 >>> >>> >>> [7] >>> >>> >>> >>> https://github.com/apache/flink-connector-elasticsearch/actions/runs/14394613238 >>> > > >