-1 (non-binding) I have tested the RC3, however I have found an issue with the source code release. It seems that the checkstyle plugin is failing the build (on my Fedora 40 Linux box with Maven 3.8.6 and Java 11/17) due to the following error:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (validate) on project flink-connector-kafka: Failed during checkstyle configuration: Exception was thrown while processing /home/tcooper/Downloads/flink-connector-kafka-4.0.0/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/config/._StartupMode.java: TokenStreamRecognitionException occurred while parsing file /home/tcooper/Downloads/flink-connector-kafka-4.0.0/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/config/._StartupMode.java. Unexpected character 0x0 in identifier -> [Help 1] This error appears to be linked to the use of non-ASCII characters. This appears to be a know limitation with checkstyle [1] that effects non-Mac OS (which I assume is why no one else has reported the issue). I checked out the release tag (v4.0.0-rc3) and ran the build from there, which passed without issues. So the issue is not with the source. However, a possible clue came when I initially unpacked the tar file. Using tar -xf on the source tar repeatedly printed the following warning: tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.apple.provenance' Is it possible that whatever tooling you used to create the source code tar file has injected characters into the files? Regards, Tom Cooper @tomcooper.dev | https://tomcooper.dev [1] https://github.com/checkstyle/checkstyle/issues/2189 On Friday, 11 April 2025 at 10:55, Arvid Heise <ahe...@confluent.io.INVALID> wrote: > Hi everyone, > Please review and vote on release candidate #3 for flink-connector-kafka > v4.0.0, as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > > The complete staging area is available for your review, which includes: > * JIRA release notes [1], > * the official Apache source release to be deployed to dist.apache.org [2], > which are signed with the key with fingerprint 538B49E9BCF0B72F [3], > * all artifacts to be deployed to the Maven Central Repository [4], > * source code tag v4.0.0-rc3 [5], > * website pull request listing the new release [6]. > * CI build of the tag [7]. > > The vote will be open for at least 72 hours. It is adopted by majority > approval, with at least 3 PMC affirmative votes. > > Thanks, > Arvid > > [1] > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352917 > [2] > https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-4.0.0-rc3 > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > [4] > https://repository.apache.org/content/repositories/staging/org/apache/flink/flink-connector-kafka/4.0.0-2.0/ > [5] https://github.com/apache/flink-connector-kafka/releases/tag/v4.0.0-rc3 > [6] https://github.com/apache/flink-web/pull/787 > [7] > https://github.com/apache/flink-connector-kafka/actions/runs/14398219463/
