Given that Flink 2.0.0 compiled with Java 17 and used a source version of Java 11 [1], we should do the same with the Kafka Connector?
Tom Cooper @tomcooper.dev | https://tomcooper.dev [1] https://github.com/apache/flink/blob/14e85eced10e98bc75870ac0360bad67d0722697/pom.xml#L127 On Wednesday, 9 April 2025 at 10:35, Xiqian YU <kono....@outlook.com> wrote: > Hi Arvid, > > I think what Kunni is mentioning is the compiled JDK version (JDK 17 here), > not the targeted class file version (JDK 8 here). The target version could be > lower than the JDK version used. > > Actual target version could be determined by executing `javap -verbose > X.class | grep version`, while the compiled JDK version could be found at > META-INF/MANIFEST.MF file. > > Best Regards, > Xiqian > > > 2025年4月9日 16:19，Arvid Heise ahe...@confluent.io.INVALID 写道： > > > > I have started another thread. Sources are unchanged and I just updated the > > binaries. > > > > However, I found something odd. The release scripts currently hard code > > Java 8 as a target. So I'm not sure how the previous binary was JDK 17. > > Unfortunately, I deleted the binaries before checking. @Yanquan Lv > > decq12y...@gmail.com , could you double check? Maybe it was major 52? > > > > Anyhow, the new binaries are major 55. I will contribute my updated release > > scripts later today. > > > > Best, > > > > Arvid > > > > On Wed, Apr 9, 2025 at 6:41 AM Arvid Heise ar...@apache.org wrote: > > > > > Hi Yanquan, > > > > > > Thank you for noticing that. I do think we should support 11 and thus I > > > will recompile it. > > > > > > I'm retracting RC1 and will build RC2 soonish. > > > > > > Best, > > > > > > Arvid > > > > > > On Wed, Apr 9, 2025, 06:22 Yanquan Lv decq12y...@gmail.com wrote: > > > > > > > Hi, Arvid. Thanks for your efforts in this release. > > > > > > > > I noticed that this released version was compiled using JDK 17, and > > > > there > > > > is also flink-connector-elasticsearch[1] support for Flink 2.0 release, > > > > which is compiled using JDK 11. > > > > I checked the compiled version of Flink 2.0 release, which is also > > > > jdk11, > > > > so it would be better for us to use this version. > > > > Our CI has already covered version 11, but I think clarifying the > > > > compiled > > > > version from the beginning will help build standards, What do you think? > > > > > > > > [1] https://lists.apache.org/thread/y9wthpvtnl18hbb3rq5fjbx8g8k6wv2m > > > > > > > > Arvid Heise ar...@apache.org 于2025年4月8日周二 22:09写道： > > > > > > > > > Hi everyone, > > > > > Please review and vote on release candidate #1 for > > > > > flink-connector-kafka > > > > > v4.0.0, as follows: > > > > > [ ] +1, Approve the release > > > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > > > > > The complete staging area is available for your review, which > > > > > includes: > > > > > * JIRA release notes [1], > > > > > * the official Apache source release to be deployed to dist.apache.org > > > > > [2], > > > > > which are signed with the key with fingerprint 538B49E9BCF0B72F [3], > > > > > * all artifacts to be deployed to the Maven Central Repository [4], > > > > > * source code tag v4.0.0-rc1 [5], > > > > > * website pull request listing the new release [6]. > > > > > * CI build of the tag [7]. > > > > > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > Thanks, > > > > > Arvid > > > > > > > > > > [1] > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352917 > > > > > > > > > [2] > > > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-4.0.0-rc1 > > > > > > > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > [4] > > > > > > > > https://repository.apache.org/content/repositories/staging/org/apache/flink/flink-connector-kafka/4.0.0-2.0/ > > > > > > > > > [5] > > > > > https://github.com/apache/flink-connector-kafka/releases/tag/v4.0.0-rc1 > > > > > [6] https://github.com/apache/flink-web/pull/787 > > > > > [7] > > > > > > > > https://github.com/apache/flink-connector-kafka/actions/runs/14334379006/job/40177587780
