Yes, I agree with your viewpoint. I created an issue[1] to trace it, and I think we can fix it as soon as possible to start a new rc. What's more, I believe that our current e2e testing does not cover such scenarios, which we need to supplement in the future.
For the 3.4 release, I think there should also be this issue, but since no one has provided feedback, I think we can wait until adding related e2e test before considering a new release, depending on the feedback from the community. [1] https://issues.apache.org/jira/browse/FLINK-37644 Arvid Heise <ar...@apache.org> 于2025年4月10日周四 04:02写道： > Hi Yanquan, > > I think you are completely right. This current state doesn't work. So I'm > calling RC2 off until we fix this issue. > > We added one code path in 3.4 (!) that made this issue probably more > obvious but the unchecked use of guava has been going on since 2 years. We > have more than 10 instances where we use Guava classes, especially in the > DynamicKafkaSource. > Would you please create a ticket for that? > > In general, we can't use flink-shaded-guava if we plan to support multiple > minor Flink version with the same source. I expect this to happen again for > later 2.X releases. > We also can't simply include guava as is because it may clash with another > connector's use of guava. > So the most logical option to me is to shade it into the base module > flink-kafka-connector and relocate it to a unique prefix > (e.g. org.apache.flink.connector.kafka). > Then SQL module will simply use that relocation transitively. > WDYT? > > Best, > > Arvid > > On Wed, Apr 9, 2025 at 6:38 PM Yanquan Lv <decq12y...@gmail.com> wrote: > > > I checked: > > - Review JIRA release notes > > - Verify hashes and verify signatures > > - Build success from source with JDK17 & maven3.8.6 > > - Source code artifacts matching the current release > > - Read the announcement blog > > - Verify that the major version is 55 > > > > > > I am trying to use the jar flink-sql-connector-kafka-4.0.0-2.0.jar[1] for > > datagen to kafka test. However, I got `java.lang.ClassNotFoundException: > > com.google.common.reflect.TypeToken` error message, I've checked that > this > > class was not included in this release jar and we did use unshaded guava > > dependencies, I think this is problematic. > > Maybe others can help confirm if this issue exists. > > > > > > [1] > > > > > https://repository.apache.org/content/repositories/staging/org/apache/flink/flink-sql-connector-kafka/4.0.0-2.0/ > > > > Arvid Heise <ar...@apache.org> 于2025年4月9日周三 16:17写道： > > > > > Hi everyone, > > > Please review and vote on release candidate #2 for > flink-connector-kafka > > > v4.0.0, as follows: > > > [ ] +1, Approve the release > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > > > > The complete staging area is available for your review, which includes: > > > * JIRA release notes [1], > > > * the official Apache source release to be deployed to dist.apache.org > > > [2], > > > which are signed with the key with fingerprint 538B49E9BCF0B72F [3], > > > * all artifacts to be deployed to the Maven Central Repository [4], > > > * source code tag v4.0.0-rc2 [5], > > > * website pull request listing the new release [6]. > > > * CI build of the tag [7]. > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > approval, with at least 3 PMC affirmative votes. > > > > > > Thanks, > > > Release Manager > > > > > > [1] > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352917 > > > [2] > > > > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-4.0.0-rc2 > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > [4] > > > > > > > > > https://repository.apache.org/content/repositories/staging/org/apache/flink/flink-connector-kafka/4.0.0-2.0/ > > > [5] > > > > https://github.com/apache/flink-connector-kafka/releases/tag/v4.0.0-rc2 > > > [6] https://github.com/apache/flink-web/pull/787 > > > [7] > > > > > > > > > https://github.com/apache/flink-connector-kafka/actions/runs/14334379006/job/40177587780 > > > > > >
