+1 (non-binding)

I agree that a release that supports 1.20 (LTS version) is more important
because adding this SQL connector to the official release also requires
development time, and it is reasonable not to block the use of more users.
Just want to confirm that we haven't missed anything important.


weijie guo <guoweijieres...@gmail.com> 于2025年4月9日周三 17:20写道:

> Hi Yanquan:
>
> > I noticed that we have supported ElasticSearch8 in this release and
> provided the flink-connector-elasticsearch8 jar[1], but we did not
> provide flink-sql-connector-elasticsearch8 jar like 6 & 7.
> Is this as expected? and do we have a plan for the release of this sql
> connector.
>
> Yes, we do not support the es8 sql connector (:. But I want to give users a
> release that supports 1.18,1.19, and 1.20 as soon as
> possible(unfortunately, the last release v3.0 was up to supports flink
> 1.17...).
>
> Anyway, what you mentioned is really a meaningful feature, but I would
> prefer to include it in next release. WDYT?
>
>
> Best regards,
>
> Weijie
>
>
> Yanquan Lv <decq12y...@gmail.com> 于2025年4月9日周三 11:30写道:
>
> > I checked:
> > - Review JIRA release notes
> > - Verify hashes and verify signatures
> > - Build success from source with JDK11 & maven3.8.6
> > - Source code artifacts matching the current release
> > - Read the announcement blog and LGTM
> >
> > I noticed that we have supported ElasticSearch8 in this release and
> > provided the flink-connector-elasticsearch8 jar[1], but we did not
> > provide flink-sql-connector-elasticsearch8 jar like 6 & 7.
> > Is this as expected? and do we have a plan for the release of this sql
> > connector.
> >
> > [1]
> >
> >
> https://repository.apache.org/content/repositories/orgapacheflink-1795/org/apache/flink
> >
> >
> > Zakelly Lan <zakelly....@gmail.com> 于2025年4月7日周一 19:44写道:
> >
> > > +1 (binding)
> > >
> > > I have verified:
> > >
> > >  - Checksum and signature
> > >  - There are no binaries in the source archive
> > >  - Release tag and staging jars
> > >  - Built from source
> > >  - Release notes and web PR
> > >
> > >
> > > Best,
> > > Zakelly
> > >
> > > On Thu, Apr 3, 2025 at 12:18 PM weijie guo <guoweijieres...@gmail.com>
> > > wrote:
> > >
> > > > Hi everyone,
> > > >
> > > >
> > > > Please review and vote on the release candidate #1 for v3.1.0, as
> > > follows:
> > > >
> > > > [ ] +1, Approve the release
> > > >
> > > > [ ] -1, Do not approve the release (please provide specific comments)
> > > >
> > > >
> > > > This release supports Flink 1.18, 1.19 and 1.20.
> > > >
> > > >
> > > > The complete staging area is available for your review, which
> includes:
> > > >
> > > > * JIRA release notes [1],
> > > >
> > > > * the official Apache source release to be deployed to
> dist.apache.org
> > > > [2],
> > > >
> > > > which are signed with the key with fingerprint
> > > > 8D56AE6E7082699A4870750EA4E8C4C05EE6861F [3],
> > > >
> > > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > >
> > > > * source code tag v3.1.0-rc1 [5],
> > > >
> > > > * website pull request listing the new release [6].
> > > >
> > > > * CI build of tag [7].
> > > >
> > > >
> > > > The vote will be open for at least 72 hours. It is adopted by
> majority
> > > >
> > > > approval, with at least 3 PMC affirmative votes.
> > > >
> > > >
> > > > Thanks,
> > > >
> > > > Weijie
> > > >
> > > >
> > > > [1]
> > > >
> > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352520
> > > >
> > > > [2]
> > > >
> > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-elasticsearch-3.1.0-rc1/
> > > >
> > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > >
> > > > [4]
> > > >
> > https://repository.apache.org/content/repositories/orgapacheflink-1795/
> > > >
> > > > [5]
> > > >
> > > >
> > > >
> > >
> >
> https://github.com/apache/flink-connector-elasticsearch/releases/tag/v3.1.0-rc1
> > > >
> > > > [6] https://github.com/apache/flink-web/pull/785
> > > >
> > > > [7]
> > > >
> > > >
> > > >
> > >
> >
> https://github.com/apache/flink-connector-elasticsearch/actions/runs/14210840013
> > > >
> > >
> >
>

Reply via email to