Hi Team, Here is the summary on the outcomes from the PR review: Externally added jars are resolved using the FlinkUserCodeClassLoader(child classloader) in flink. This fix involved updating the class loader at the graph execution level with the user code class loader which is expected as per naming convention of the variable here[1] in the source code. However, the issue is already fixed in a safe tested way in Flink 2.0 as part of this PR[2]. If this issue exists for several Flink versions (from 1.16) then we should not introduce large and risky changes in a patch version to fix it. Since the issue has existed since version 1.16 (over 2 years) and is only relevant for the Table API the risk is not worth it [3]. So we can conclude that ADD JAR capability with Table API will be a known limitation till version 20 and the same can be used with Flink 2.0. Based on this I believe we are good to close the PR[4] and tag the fix version for the related issue[5] as 2.0. However I’d love to hear your thoughts on this. Please let me know if there are any suggestions or concerns.
[1] https://github.com/apache/flink/blob/a4563caa7a4914dfd9fa5d488f5b2e541ecc582a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java#L2472 [2] https://github.com/apache/flink/pull/25472 [3] https://github.com/apache/flink/pull/25656#issuecomment-2582320914 [4] https://github.com/apache/flink/pull/25656 [5] https://issues.apache.org/jira/browse/FLINK-28897 Regards, Ammu > On 29 Nov 2024, at 11:49 AM, Ammu P <ammup...@gmail.com> wrote: > > Hi Team, > > I have raised a PR (https://github.com/apache/flink/pull/25656) to 1.20 > version with probable fix for this issue. Can I get a review done for this > please. Thanks in advance. > > Regards, > Ammu Parvathy > On 2022/08/10 03:39:00 "Liu (Jira)" wrote: > > Liu created FLINK-28897: > > --------------------------- > > > > Summary: Fail to use udf in added jar when enabling checkpoint > > Key: FLINK-28897 > > URL: https://issues.apache.org/jira/browse/FLINK-28897 > > Project: Flink > > Issue Type: Bug > > Affects Versions: 1.16.0 > > Reporter: Liu > > > > > > > > > > > > > > -- > > This message was sent by Atlassian Jira > > (v8.20.10#820010) > >
