+1 (binding) - maven staging repo contents look fine - src archive looks fine - local cluster starts on macos from binary release artifacts
On Tue, Feb 11, 2025 at 1:38 PM Leonard Xu <xbjt...@gmail.com> wrote: > +1 (binding) > > - verified signatures > - verified hashsums > - built from source code with JDK 1.8 succeeded > - checked Github release tag > - checked release notes > - reviewed the web PR > > Best, > Leonard > > > 2025年2月11日 19:09，Márton Balassi <balassi.mar...@gmail.com> 写道： > > > > +1 (binding) > > > > 1. Verified the archives, checksums, and signatures > > 2. Extracted and inspected the source code for binaries > > 3. Built the source code > > 4. Verified license files / headers > > > > Best, > > Marton > > > > On Mon, Feb 3, 2025 at 12:37 PM Maximilian Michels <m...@apache.org> > wrote: > > > >> +1 (binding) > >> > >> 1. Verified the archives, checksums, and signatures > >> 2. Extracted and inspected the source code for binaries > >> 3. Built the source code > >> 4. Verified license files / headers > >> > >> Sergey wrote: > >>> one minor finding: > >>> in staging repos [1] it has wrong description (1.9.2 instead of 1.19.2) > >> > >> Good catch Sergey! > >> > >> Alex wrote: > >>> I realized I made a typo after publishing the staging artifacts. > >>> Renaming is not allowed, unfortunately. > >> > >> No worries, the description won't be relevant beyond the staging > >> phase. We use the direct link to verify, which you supplied. Besides, > >> Apache releases formally only require proper source code. > >> > >> Thanks for doing the release! > >> > >> -Max > >> > >> On Mon, Feb 3, 2025 at 11:57 AM Alexander Fedulov > >> <alexander.fedu...@gmail.com> wrote: > >>> > >>>> one minor finding: > >>>> in staging repos [1] it has wrong description (1.9.2 instead of > 1.19.2) > >>> > >>> I realized I made a typo after publishing the staging artifacts. > >>> Renaming is not allowed, unfortunately. > >>> As far as I can tell, it is only relevant for the staging area itself, > >>> so, unless I am missing something, I believe it is not needed to start > >>> over just because of it. > >>> > >>> Best, > >>> Ale > >>> > >>> On Mon, 3 Feb 2025 at 00:37, Sergey Nuyanzin <snuyan...@gmail.com> > >> wrote: > >>>> > >>>> +1 (non-binfing) > >>>> > >>>> one minor finding: > >>>> in staging repos [1] it has wrong description (1.9.2 instead of > 1.19.2) > >>>> > >>>> > >>>> - verified signatures && hashsums > >>>> - checked git tag > >>>> - checked no binaries in source files > >>>> - built the source with jdk1.8 and maven 3.8.6 > >>>> > >>>> [1] https://repository.apache.org/#stagingRepositories > >>>> > >>>> On Thu, Jan 30, 2025 at 5:45 PM Ferenc Csaky > >> <ferenc.cs...@pm.me.invalid> > >>>> wrote: > >>>> > >>>>> +1 (non-binfing) > >>>>> > >>>>> - verified signatures > >>>>> - verified hashsums > >>>>> - checked GH release tag > >>>>> - checked no binaries in source archives > >>>>> - built the source with jdk8 and maven 3.8.6 > >>>>> - reviewed web PR > >>>>> - deployed WordCount job to local cluster > >>>>> > >>>>> Thanks, > >>>>> Ferenc > >>>>> > >>>>> > >>>>> > >>>>> > >>>>> On Thursday, January 30th, 2025 at 03:22, Yanquan Lv < > >> decq12y...@gmail.com> > >>>>> wrote: > >>>>> > >>>>>> > >>>>>> > >>>>>> +1 (non-binding) > >>>>>> > >>>>>> I checked: > >>>>>> - Review JIRA release notes > >>>>>> - Verify hashes and verify signatures > >>>>>> - Build success from source with JDK11 & maven3.8.6 > >>>>>> - Source code artifacts matching the current release > >>>>>> - Read the announcement blog and LGTM > >>>>>> > >>>>>> ---------- Forwarded message --------- > >>>>>> 发件人： Alexander Fedulov alexander.fedu...@gmail.com > >>>>>> > >>>>>> Date: 2025年1月29日周三 上午1:30 > >>>>>> Subject: [VOTE] Release 1.19.2, release candidate #1 > >>>>>> To: dev dev@flink.apache.org > >>>>>> > >>>>>> > >>>>>> > >>>>>> Hi everyone, > >>>>>> > >>>>>> Please review and vote on the release candidate #1 for the version > >>>>>> 1.19.2, as follows: > >>>>>> [ ] +1, Approve the release > >>>>>> [ ] -1, Do not approve the release (please provide specific > >> comments) > >>>>>> > >>>>>> The staging area contains the following artifacts: > >>>>>> * JIRA release notes [1], > >>>>>> * the official Apache source release and binary convenience > >> releases > >>>>>> to be deployed to dist.apache.org [2], which are signed with the > >> key > >>>>>> with fingerprint 8C1FC56D16B0029D [3], > >>>>>> * all artifacts to be deployed to the Maven Central Repository [4], > >>>>>> * source code tag "release-1.19.2-rc1" [5], > >>>>>> * website pull request listing the new release and adding > >> announcement > >>>>>> blog post [6]. > >>>>>> > >>>>>> The vote will be open for at least 72 hours. It is adopted by > >> majority > >>>>>> approval, with at least 3 PMC affirmative votes. > >>>>>> > >>>>>> Verification instruction can be found here [7] . You’re not > >> required > >>>>>> to verify everything, but please mention what you have tested along > >>>>>> with your +/- vote. > >>>>>> > >>>>>> Thanks, > >>>>>> Alex > >>>>>> > >>>>>> [1] > >>>>>> > >>>>> > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12354783 > >>>>>> [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.19.2-rc1/ > >>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > >>>>>> [4] > >>>>>> > >>>>> > >> > https://repository.apache.org/content/repositories/orgapacheflink-1782/org/apache/flink/ > >>>>>> [5] https://github.com/apache/flink/tree/release-1.19.2-rc1 > >>>>>> [6] https://github.com/apache/flink-web/pull/771 > >>>>>> [7] > >>>>>> > >>>>> > >> > https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Release > >>>>> > >>>> > >>>> > >>>> -- > >>>> Best regards, > >>>> Sergey > >> > >
