Thanks Timo,
I fixed the example
I'm going to start the voting then in a separate thread
On Thu, Dec 19, 2024 at 12:32 PM Timo Walther <twal...@apache.org> wrote:
> Hi Sergey,
>
> thanks for working on this. The FLIP is a nice continuation of started
> efforts. The example of createTable doesn't use the flag. Otherwise +1
> to vote, as it is not very controversial.
>
> Cheers,
> Timo
>
> On 18.12.24 09:35, Sergey Nuyanzin wrote:
> > Hi Ron,
> >
> > good catch,
> > I fixed it
> > thanks
> >
> > On Wed, Dec 18, 2024 at 3:27 AM Ron Liu <ron9....@gmail.com> wrote:
> >
> >> Hi Sergey
> >>
> >> Thanks for driving this FLIP, +1.
> >>
> >> It may be a minor typo for the createTable method doc.
> >>
> >> ```
> >>
> >> * <pre>{@code
> >> * tEnv.createTemporaryTable("MyTable",
> >> TableDescriptor.forConnector("datagen")
> >> * .schema(Schema.newBuilder()
> >> * .column("f0", DataTypes.STRING())
> >> * .build())
> >> * .option(DataGenOptions.ROWS_PER_SECOND, 10)
> >> * .option("fields.f0.kind", "random")
> >> * .build());
> >> * }</pre>
> >>
> >> ```
> >>
> >> Should `tEnv.createTemporaryTable` be `tEnv.createTable`?
> >>
> >>
> >> Best
> >> Ron
> >>
> >> Sergey Nuyanzin <snuyan...@gmail.com> 于2024年12月18日周三 06:12写道：
> >>
> >>> Hi all!
> >>>
> >>> I would like to open up for discussion another new small FLIP-494[1].
> >>>
> >>> Motivation
> >>> This FLIP continues the journey of bringing Table API and FlinkSQL
> closer
> >>> to each other.
> >>> It adds missing create methods to TableEnvironment (alter functionality
> >>> will be added in follow up FLIP(s)).
> >>> There are already existing createTemporaryTable, createTable and
> >>> createTemporaryView however still missing createView and createTable
> with
> >>> ignoreIfExists flag
> >>>
> >>> [1]
> >>>
> >>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=334760466
> >>>
> >>>
> >>> --
> >>> Best regards,
> >>> Sergey
> >>>
> >>
> >
> >
>
>
--
Best regards,
Sergey
