> While reading it was surprised that the
> create functions like `createTable` return void.

>The suggestion to return boolean like the other drop methods seems good.

Thanks for the feedback.
I agree there is a number of things which could be improved in this
interface including the one you've mentioned.
However I'd like to go step by step and within this FLIP focus only on
dropTable/dropView methods.
Other improvements could come with follow up FLIPs


On Sat, Dec 7, 2024 at 1:17 AM Jim Hughes <jhug...@confluent.io.invalid>
wrote:

> Hi Sergey,
>
> Nice!  Seems straightforward...  While reading it was surprised that the
> create functions like `createTable` return void.
>
> The suggestion to return boolean like the other drop methods seems good.
>
> Cheers,
>
> Jim
>
> On Fri, Dec 6, 2024 at 5:53 PM Sergey Nuyanzin <snuyan...@gmail.com>
> wrote:
>
> > Hi all!
> >
> > I would like to open up for discussion a new small FLIP-489[1].
> >
> > Motivation
> > This FLIP is another step in the story of bringing Table API and FlinkSQL
> > closer to each other.
> > It adds missing drop methods to TableEnvironment (alter functionality
> will
> > be added in follow up FLIP(s)).
> > There are already existing dropTemporaryTable and dropTemporaryView
> however
> > still missing dropTable and dropView
> >
> > [1]
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=332499781
> >
> > --
> > Best regards,
> > Sergey
> >
>


-- 
Best regards,
Sergey

Reply via email to