+1 (binding) - Validated hashes - Verified signature - Verified that no binaries exist in the source archive - Build the source with Maven - Verified licenses - Verified web PR
On Thu, Nov 21, 2024 at 9:56 AM Leonard Xu <xbjt...@gmail.com> wrote: > +1 (binding) > > - verified signatures > - verified hashsums > - checked Github release tag, NOTE: the code branch v3.4 is missed and > should be created before release > - built from source code with JDK 1.8 succeeded > - checked release notes > - reviewed the web PR > > Best, > Leonard > > > > On Nov 15, 2024, at 10:00 AM, Yanquan Lv <decq12y...@gmail.com> wrote: > > > > Thanks Arvid for driving it. > > > > +1 (non-binding) > > I checked: > > - Review JIRA release notes > > - Verify hashes and verify signatures > > - Build success from source with JDK11 & maven3.8.6 > > - Source code artifacts matching the current release > > - Read the announcement blog and LGTM > > > > > >> 2024年11月15日 04:01,Arvid Heise <ar...@apache.org> 写道: > >> > >> Hi everyone, > >> > >> Please review and vote on release candidate #1 for flink-connector-kafka > >> v3.4.0, as follows: > >> > >> [ ] +1, Approve the release > >> > >> [ ] -1, Do not approve the release (please provide specific comments) > >> > >> > >> > >> > >> > >> The complete staging area is available for your review, which includes: > >> > >> * JIRA release notes [1], > >> > >> * the official Apache source release to be deployed to dist.apache.org > [2], > >> which are signed with the key with fingerprint 538B49E9BCF0B72F [3], > >> > >> * all artifacts to be deployed to the Maven Central Repository [4], > >> > >> * source code tag v3.4.0-rc1 [5], > >> > >> * website pull request listing the new release [6]. > >> > >> * CI build of the tag [7]. > >> > >> > >> > >> The vote will be open for at least 72 hours. It is adopted by majority > >> approval, with at least 3 PMC affirmative votes. > >> > >> > >> > >> Thanks, > >> > >> Arvid - Release Manager > >> > >> > >> > >> [1] > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12355224 > >> > >> [2] > >> > https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.4.0-rc1 > >> > >> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > >> > >> [4] > >> > https://repository.apache.org/content/repositories/staging/org/apache/flink/flink-connector-kafka/3.4.0-1.20/ > >> > >> [5] > https://github.com/apache/flink-connector-kafka/releases/tag/v3.4.0-rc1 > >> > >> [6] https://github.com/apache/flink-web/pull/763/files > >> > >> [7] > https://github.com/apache/flink-connector-kafka/actions/runs/11842227966 > > > >