+1 (non-binding)

- Built from source with JDK 11
- Verified checksum and signatures
- Verified source code does not contain binaries
- Verified artifacts deployed to the maven repository
- Verified no binaries in source release
- Reviewed flink-web PR

Thank you for driving this release Ferenc!

Best,
Mate


Attila Kreiner <attila.krei...@cloudera.com.invalid> ezt írta (időpont:
2024. nov. 13., Sze, 15:51):

> +1 (non-binding)
> Checked:
> - Built from source with jdk 11, maven 3.8.6
> - Reviewed release notes
> - Verified hash & signature
> - Source code artifacts match the current release
>
> On Wed, Nov 13, 2024 at 6:42 AM Yanquan Lv <decq12y...@gmail.com> wrote:
>
> > +1 (non-binding)
> > I checked:
> > - Review JIRA release notes
> > - Verify hashes and verify signatures
> > - Build success from source with JDK11 & maven3.8.6
> > - Source code artifacts matching the current release
> >
> >
> >
> > > 2024年11月12日 19:00,Yanquan Lv <decq12y...@gmail.com> 写道:
> > >
> > > Hi, Ferenc.
> > > I found an issue during verification, current release file name
> included
> > specific version of 1.18.1 & 1.19.1[1], refer to pre discussion in
> > flink-connector-kafka v3.3.0[2],  this may cause users to misunderstand
> > that other versions are not available.
> > >
> > > [1]
> >
> https://repository.apache.org/content/repositories/orgapacheflink-1768/org/apache/flink/flink-sql-connector-hbase-2.2/
> > > [2]https://lists.apache.org/thread/hfocjggnj4m50l0gl25g1bgg77wzh8bl
> > >
> > >> 2024年11月9日 01:22,Ferenc Csaky <ferenc.cs...@pm.me.INVALID> 写道:
> > >>
> > >> Hi everyone,
> > >>
> > >> Please review and vote on release candidate #1 for
> > flink-connector-hbase v4.0.0, as
> > >> follows:
> > >> [ ] +1, Approve the release
> > >> [ ] -1, Do not approve the release (please provide specific comments)
> > >>
> > >> The complete staging area is available for your review, which
> includes:
> > >> * JIRA release notes [1],
> > >> * the official Apache source release to be deployed to
> dist.apache.org
> > [2],
> > >> which are signed with the key with fingerprint 16AE0DDBBB2F380B [3],
> > >> * all artifacts to be deployed to the Maven Central Repository [4],
> > >> * source code tag v4.0.0-rc1 [5],
> > >> * website pull request listing the new release [6],
> > >> * CI build of the tag [7].
> > >>
> > >> The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least
> > >> 3 PMC affirmative votes.
> > >>
> > >> Thanks,
> > >> Ferenc
> > >>
> > >> [1]
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12354393
> > >> [2]
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-hbase-4.0.0-rc1
> > >> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > >> [4]
> > https://repository.apache.org/content/repositories/orgapacheflink-1768
> > >> [5]
> > https://github.com/apache/flink-connector-hbase/releases/tag/v4.0.0-rc1
> > >> [6] https://github.com/apache/flink-web/pull/762[7]
> > https://github.com/apache/flink-connector-hbase/actions/runs/11745320515
> > >
> >
> >
>

Reply via email to