Hi Dawid,
thanks for starting this thread. It is very unfortunate that we did not
spot this issue earlier when implementing window TVFs. But I agree that
this is a bug. Unless somebody can provide a reason why window start/end
always use TIMESTAMP and don't adapt to TIMESTAMP_LTZ?
If I remember correctly, Leonard Xu worked on the
TIMESTAMP/TIMESTAMP_LTZ support for window and give more background?
I would be fine with CompiledPlan backwards compatibility.
Regards,
Timo
On 06.11.24 15:38, Dawid Wysakowicz wrote:
Hi all,
I wanted to bring your attention to FLINK-36665[1].
I believe the current behaviour is confusing and I'd like to fix it.
However, since window operations are a very important feature I'd like to
gather feedback on to what extent we should keep backwards compatibility.
1. How should newly submitted queries behave? Are we fine with changing
the inference of these functions or would you prefer to have a feature flag
that would let us revert to the old inference logic? My preference would be
to simply change the inference. The current behaviour is very confusing and
I'd keep the behaviour for restored queries (see 2.)
2. My plan for migrated queries (queries restored from a compiled plan)
is that they won't be impacted. They'll keep producing the same results. We
have the output types serialized in the compiled plan which we can use to
produce the same type as before.
What do you think?
Best,
Dawid
[1] https://issues.apache.org/jira/browse/FLINK-36665
