+1 (non-binding)

- Verified checksums and signatures
- Verified no binary files
- Verified all source files contain Apache license header
- Suspended job with 1.9.0 Operator, upgraded to 1.10.0, restarted job
- Verified manual/periodic/upgrade FlinkStateSnapshot resources

However with `helm upgrade`, the new FlinkStateSnapshot CRD won't be
installed, and the docs don't cover this. I have created a PR to fix this
[1].

[1] https://github.com/apache/flink-kubernetes-operator/pull/905

Yuepeng Pan <panyuep...@apache.org> ezt írta (időpont: 2024. okt. 21., H,
11:35):

> +1 (non-binding)
>
> I verified that:
> - Build from source on local PC with JDK-17.0.12- Check versions.- Run a
> wordcount demo on colima + docker + minikube
>
>
>
> Best,
> Yuepeng Pan
>
>
>
>
>
> At 2024-10-18 15:47:50, "Gabor Somogyi" <gabor.g.somo...@gmail.com> wrote:
> >+1 (non-binding)
> >
> >* Verified versions in the poms
> >* Built from source
> >* Verified checksums and signatures
> >* Started basic workload
> >* Verified NOTICE and LICENSE files
> >
> >G
> >
> >
> >On Fri, Oct 18, 2024 at 4:45 AM Sam Barker <s...@quadrocket.co.uk> wrote:
> >
> >> +1 (non binding)
> >>
> >> I've verified:
> >> - The src tarball builds and passes mvn verify (with Java 17),
> >> - the sha512 signatures for both srcs and helm
> >> - The GPG
> >> - Checked all poms are version 1.10.0
> >> - Checked all poms do not contain -SNAPSHOT dependencies
> >> - Verified that the chart and appVersions from the helm tarball are
> 1.10.0
> >> - Verified the chart points at the appropriate image
> >> - Verified that the the RC repo works as a helm Repo
> >>
> >> On Wed, 16 Oct 2024 at 05:18, Őrhidi Mátyás <matyas.orh...@gmail.com>
> >> wrote:
> >>
> >> > Hi everyone,
> >> >
> >> > Please review and vote on the release candidate #1 for the version
> 1.10.0
> >> > of Apache Flink Kubernetes Operator,
> >> > as follows:
> >> > [ ] +1, Approve the release
> >> > [ ] -1, Do not approve the release (please provide specific comments)
> >> >
> >> > **Release Overview**
> >> >
> >> > As an overview, the release consists of the following:
> >> > a) Kubernetes Operator canonical source distribution (including the
> >> > Dockerfile), to be deployed to the release repository at
> dist.apache.org
> >> > b) Kubernetes Operator Helm Chart to be deployed to the release
> >> repository
> >> > at dist.apache.org
> >> > c) Maven artifacts to be deployed to the Maven Central Repository
> >> > d) Docker image to be pushed to dockerhub
> >> >
> >> > **Staging Areas to Review**
> >> >
> >> > The staging areas containing the above mentioned artifacts are as
> >> follows,
> >> > for your review:
> >> > * All artifacts for a,b) can be found in the corresponding dev
> repository
> >> > at dist.apache.org [1]
> >> > * All artifacts for c) can be found at the Apache Nexus Repository [2]
> >> > * The docker image for d) is staged on github [3]
> >> >
> >> > All artifacts are signed with the key 48E78F054AA33CB5 [4]
> >> >
> >> > Other links for your review:
> >> > * JIRA release notes [5]
> >> > * source code tag "release-1.1.0-rc1" [6]
> >> > * PR to update the website Downloads page to include Kubernetes
> Operator
> >> > links [7]
> >> >
> >> > **Vote Duration**
> >> >
> >> > The voting time will run for at least 72 hours.
> >> > It is adopted by majority approval, with at least 3 PMC affirmative
> >> votes.
> >> >
> >> > **Note on Verification**
> >> >
> >> > You can follow the basic verification guide here[8].
> >> > Note that you don't need to verify everything yourself, but please
> make
> >> > note of what you have tested together with your +- vote.
> >> >
> >> > Thanks,
> >> > Matyas
> >> >
> >> > [1]
> >> >
> >> >
> >>
> https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-1.10.0-rc1/
> >> > [2]
> >> https://repository.apache.org/content/repositories/orgapacheflink-1762
> >> >  [3] ghcr.io/apache/flink-kubernetes-operator:c703255
> >> >  [4]    https://dist.apache.org/repos/dist/release/flink/KEYS
> >> > [5]
> >> >
> >> >
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12354833
> >> > [6]
> >> >
> >> >
> >>
> https://github.com/apache/flink-kubernetes-operator/releases/tag/release-1.10.0-rc1
> >> > [7] https://github.com/apache/flink-web/pull/758
> >> >  [8]
> >> >
> >> >
> >>
> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Kubernetes+Operator+Release
> >> >
> >> >
> >> >
> >> >
> >> >
> >> >
> >> >
> >> > ghcr.io/apache/flink-kubernetes-operator:c703255
> >> >
> >>
>

Reply via email to