Jörn Kottmann created FLINK-36138:
-------------------------------------

             Summary: KinesisStreamsSource.buil() should have helpful null 
errors
                 Key: FLINK-36138
                 URL: https://issues.apache.org/jira/browse/FLINK-36138
             Project: Flink
          Issue Type: Improvement
          Components: Connectors / AWS
    Affects Versions: 1.19.1
            Reporter: Jörn Kottmann


The KinesisStreamsSource is constructed with a help of a builder, in order to 
successfully create an instance all fields that are null checked need to be 
provided by invoking the builders set methods.

In case one required field is not set it will remain null und result in a 
failure of Preconditions.checkNotNull. This exception currently doesn't say 
which field is null, therefore it is only possible to resolve the error by 
looking at the code (the JavaDoc explains it as well, but is missing the 
sourceConfig field)

 

I would like to propose to communicate to the user which field must be set in 
the thrown exception.

 

In case this can be addressed, I would like to provide a PR to fix it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to