Hi! Thanks Gabor for looking into this. +1 for removing the DataSet based APIs from the state processor in the next Flink version, I don't think we should wait until 2.0. This will also reduce the 2.0 scope overall which is always good :)
Cheers, Gyula On Wed, Jul 31, 2024 at 10:30 AM Gabor Somogyi <gabor.g.somo...@gmail.com> wrote: > Hi Devs, > > There is a common agreement that the dataset API going to be removed in > 2.0. > > We're planning to invest quite some time in the State Processor API[1] in > the near future. > On this road we've realized that there are several deprecated APIs in this > area which are based > on the dataset API (for example Savepoint, ExistingSavepoint, NewSavepoint, > etc...) [2]. > > Based on the dataset removal agreement these are going to be removed but in > order to ease > our efforts it would be good to remove them now. The question is whether > it's fine to do it > or there are some reasons not to do so? > > Here are the collected facts about the APIs to help forming an opinion: > * Example intended to remove class: Savepoint (others share the same > characteristics) > * API marker: PublicEvolving > * Marked deprecated in: FLINK-24912 [3] > * Deprecation date: 22/12/2021 > * Deprecation in Flink version: 1.15.0 > * Eligible for removal according to our deprecation process [4]: 1.16.0+ > * New replacement APIs: SavepointReader, SavepointWriter > > Please share your thoughts on this. > > [1] > > https://nightlies.apache.org/flink/flink-docs-release-1.20/docs/libs/state_processor_api/ > [2] > > https://github.com/apache/flink/blob/82b628d4730eef32b2f7a022e3b73cb18f950e6e/flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/Savepoint.java#L47-L49 > [3] https://issues.apache.org/jira/browse/FLINK-24912 > [4] > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-321%3A+Introduce+an+API+deprecation+process > > BR, > G >
