+1 (binding) Verified: - Sources/signates - Install 1.9.0 from helm chart - Stateful example job basic interactions - Operator upgrade from 1.8.0 -> 1.9.0 with running flinkdeployments - Flink-web PR looks good
Cheers, Gyula On Wed, Jun 19, 2024 at 12:09 PM Gyula Fóra <gyula.f...@gmail.com> wrote: > Hi, > > I have updated the KEYs file and extended the expiration date so that > should not be an issue. Thanks for pointing that out. > > Gyula > > On Wed, 19 Jun 2024 at 12:07, Rui Fan <1996fan...@gmail.com> wrote: > >> Thanks Gyula and Mate for driving this release! >> >> +1 (binding) >> >> Except the key is expired, and leaving a couple of comments to the >> flink-web PR, >> the rest of them are fine. >> >> - Downloaded artifacts from dist ( svn co https://dist.apache >> .org/repos/dist/dev/flink/flink-kubernetes-operator-1.9.0-rc1/ ) >> - Verified SHA512 checksums : ( for i in *.tgz; do echo $i; sha512sum >> --check $i.sha512; done ) >> - Verified GPG signatures : ( for i in *.tgz; do echo $i; gpg --verify >> $i.asc $i; done) >> - Build the source with java-11 and java-17 ( mvn -T 20 clean install >> -DskipTests ) >> - Verified the license header during build the source >> - Verified that chart and appVersion matches the target release (less the >> index.yaml and Chart.yaml ) >> - Download Autoscaler standalone: wget https://repository.apache >> .org/content/repositories/orgapacheflink-1740/org/apache/flink/flink >> -autoscaler-standalone/1.9.0/flink-autoscaler-standalone-1.9.0.jar >> - Ran Autoscaler standalone locally, it works well with rescale api. >> >> Best, >> Rui >> >> On Wed, Jun 19, 2024 at 1:50 AM Mate Czagany <czmat...@gmail.com> wrote: >> >> > Hi, >> > >> > +1 (non-binding) >> > >> > Note: Using the Apache Flink KEYS file [1] to verify the signatures your >> > key seems to be expired, so that file should be updated as well. >> > >> > - Verified checksums and signatures >> > - Built source distribution >> > - Verified all pom.xml versions are the same >> > - Verified install from RC repo >> > - Verified Chart.yaml and values.yaml contents >> > - Submitted basic example with 1.17 and 1.19 Flink versions in native >> and >> > standalone mode >> > - Tested operator HA, added new watched namespace dynamically >> > - Checked operator logs >> > >> > Regards, >> > Mate >> > >> > [1] https://dist.apache.org/repos/dist/release/flink/KEYS >> > >> > Gyula Fóra <gyula.f...@gmail.com> ezt írta (időpont: 2024. jún. 18., K, >> > 8:14): >> > >> > > Hi Everyone, >> > > >> > > Please review and vote on the release candidate #1 for the version >> 1.9.0 >> > of >> > > Apache Flink Kubernetes Operator, >> > > as follows: >> > > [ ] +1, Approve the release >> > > [ ] -1, Do not approve the release (please provide specific comments) >> > > >> > > **Release Overview** >> > > >> > > As an overview, the release consists of the following: >> > > a) Kubernetes Operator canonical source distribution (including the >> > > Dockerfile), to be deployed to the release repository at >> dist.apache.org >> > > b) Kubernetes Operator Helm Chart to be deployed to the release >> > repository >> > > at dist.apache.org >> > > c) Maven artifacts to be deployed to the Maven Central Repository >> > > d) Docker image to be pushed to dockerhub >> > > >> > > **Staging Areas to Review** >> > > >> > > The staging areas containing the above mentioned artifacts are as >> > follows, >> > > for your review: >> > > * All artifacts for a,b) can be found in the corresponding dev >> repository >> > > at dist.apache.org [1] >> > > * All artifacts for c) can be found at the Apache Nexus Repository [2] >> > > * The docker image for d) is staged on github [3] >> > > >> > > All artifacts are signed with the key 21F06303B87DAFF1 [4] >> > > >> > > Other links for your review: >> > > * JIRA release notes [5] >> > > * source code tag "release-1.9.0-rc1" [6] >> > > * PR to update the website Downloads page to >> > > include Kubernetes Operator links [7] >> > > >> > > **Vote Duration** >> > > >> > > The voting time will run for at least 72 hours. >> > > It is adopted by majority approval, with at least 3 PMC affirmative >> > votes. >> > > >> > > **Note on Verification** >> > > >> > > You can follow the basic verification guide here[8]. >> > > Note that you don't need to verify everything yourself, but please >> make >> > > note of what you have tested together with your +- vote. >> > > >> > > Cheers! >> > > Gyula Fora >> > > >> > > [1] >> > > >> > > >> > >> https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-1.9.0-rc1/ >> > > [2] >> > > >> https://repository.apache.org/content/repositories/orgapacheflink-1740/ >> > > [3] ghcr.io/apache/flink-kubernetes-operator:17129ff >> > > [4] https://dist.apache.org/repos/dist/release/flink/KEYS >> > > [5] >> > > >> > > >> > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12354417 >> > > [6] >> > > >> > >> https://github.com/apache/flink-kubernetes-operator/tree/release-1.9.0-rc1 >> > > [7] https://github.com/apache/flink-web/pull/747 >> > > [8] >> > > >> > > >> > >> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Kubernetes+Operator+Release >> > > >> > >> >
