Hi Ferenc, About the deprecation process, removing a @Public API requires the API to be deprecated for at least 2 minor releases AND the removal should be in a major version bump. That means you cannot remove a @Public API in 2.x when x is not 0. The tricky part is, run-application as a command-line interface does not have any @Public/@PublicEvolving/@Experimental/@Deprecated annotations (nor CliFrontend, the class it is defined in). Command-line interfaces are definitely public APIs IMO, but there's no explicit deprecation process for them, which also means we never committed that command-line interfaces will stay compatible.
My suggestion would be to start a separate discussion thread on whether and how to add explicit compatibility guarantees for command-line interfaces. Without that, "legally" we can change command-line interfaces anytime, though I'd be negative doing so. As for the PR, I'd be in favor of not merging it for 1.20. Because we have passed the feature freeze date for half a week and the PR is still not yet reviewed, and the necessity for making it into 1.20 is unclear due to absence of explicit process. Best, Xintong On Wed, Jun 19, 2024 at 1:33 AM Ferenc Csaky <ferenc.cs...@pm.me.invalid> wrote: > Hi Robert, Rui, Ufuk, and Weijie, > > I would like to raise the PR about merging `flink run` and > `flink run-application` functionality [1] to get considered as > part of the 1.20 release. > > The reason IMO is that the `run-application` CLI command should be > removed in the same release when Per-Job mode gets removed. AFAIK > when we deprecate a public API, it has to stay for 2 minor > releases to give time for users to adapt. According to that, if > `run-application` is deprecated in Flink 2.0, it can get removed > in Flink 2.3. Currently the drop of per-job mode is blocked [2] > and probably it will not be resolved for a while, but I could > imagine it would be possible in 2.1 or 2.2. > > The change itself is rather small and concise, and Marton Balassi > volunteered to review it ASAP. > > Pls. correct me if I am wrong about the deprecation process. > > Looking forward to your opinion! > > Thanks, > Ferenc > > [1] https://issues.apache.org/jira/browse/FLINK-35625 > [2] https://issues.apache.org/jira/browse/FLINK-26000 > > > On Tuesday, 18 June 2024 at 11:27, weijie guo <guoweijieres...@gmail.com> > wrote: > > > > > > > Hi Zakelly, > > > > Thank you for informing us! > > > > After discussion, all RMs agreed that this was an important fix that > should > > be merged into 1.20. > > > > So feel free to merge it. > > > > Best regards, > > > > Weijie > > > > > > Zakelly Lan zakelly....@gmail.com 于2024年6月15日周六 16:29写道： > > > > > Hi Robert, Rui, Ufuk and Weijie, > > > > > > Thanks for the update! > > > > > > FYI: This PR[1] fixes & cleanup the left-over checkpoint directories > for > > > file-merging on TM exit. And the second commit fixes the wrong state > handle > > > usage. We encountered several unexpected CI fails, so we missed the > feature > > > freeze time. It is better to have this PR in 1.20 so I will merge this > if > > > you agree. Thanks. > > > > > > [1] https://github.com/apache/flink/pull/24933 > > > > > > Best, > > > Zakelly > > > > > > On Sat, Jun 15, 2024 at 6:00 AM weijie guo guoweijieres...@gmail.com > > > wrote: > > > > > > > Hi everyone, > > > > > > > > The feature freeze of 1.20 has started now. That means that no new > > > > features > > > > > > > > or improvements should now be merged into the master branch unless > you > > > > ask > > > > > > > > the release managers first, which has already been done for PRs, or > > > > pending > > > > > > > > on CI to pass. Bug fixes and documentation PRs can still be merged. > > > > > > > > - Cutting release branch > > > > > > > > Currently we have no blocker issues(beside tickets that used for > > > > release-testing). > > > > > > > > We are planning to cut the release branch on next Friday (June 21) if > > > > no new test instabilities, and we'll make another announcement in the > > > > dev mailing list then. > > > > > > > > - Cross-team testing > > > > > > > > The release testing will start right after we cut the release branch, > > > > which > > > > > > > > is expected to come in the next week. As a prerequisite of it, we > have > > > > created > > > > > > > > the corresponding instruction ticket in FLINK-35602 [1], please check > > > > and complete the > > > > > > > > documentation and test instruction of your new feature and mark the > > > > related JIRA > > > > > > > > issue in the 1.20 release wiki page [2] before we start testing, > which > > > > > > > > would be quite helpful for other developers to validate your > features. > > > > > > > > Best regards, > > > > > > > > Robert, Rui, Ufuk and Weijie > > > > > > > > [1]https://issues.apache.org/jira/browse/FLINK-35602 > > > > > > > > [2] https://cwiki.apache.org/confluence/display/FLINK/1.20+Release >
