+1 (binding) * Downloaded all artifacts * Extracted sources and ran compilation on sources * Diff of git tag checkout with downloaded sources * Verified SHA512 & GPG checksums * Checked that all POMs have the right expected version * Generated diffs to compare pom file changes with NOTICE files * Verified WordCount in batch mode and streaming mode with a standalone session cluster to verify the logs: no suspicious behavior observed
Best, Matthias On Mon, Jun 10, 2024 at 12:54 PM Hong Liang <h...@apache.org> wrote: > Thanks for testing the release candidate, everyone. Nice to see coverage on > different types of testing being done. > > I've addressed the comments on the web PR - thanks Rui Fan for good > comments, and for the reminder from Ahmed :) > > We have <24 hours on the vote wait time, and still waiting on 1 more > binding vote! > > Regards, > Hong > > On Sat, Jun 8, 2024 at 11:33 PM Ahmed Hamdy <hamdy10...@gmail.com> wrote: > > > Hi Hong, > > Thanks for driving > > > > +1 (non-binding) > > > > - Verified signatures and hashes > > - Checked github release tag > > - Verified licenses > > - Checked that the source code does not contain binaries > > - Reviewed Web PR, nit: Could we address the comment of adding > FLINK-34633 > > in the release > > > > > > Best Regards > > Ahmed Hamdy > > > > > > On Sat, 8 Jun 2024 at 22:22, Jeyhun Karimov <je.kari...@gmail.com> > wrote: > > > > > Hi Hong, > > > > > > Thanks for driving the release. > > > +1 (non-binding) > > > > > > - Verified gpg signature > > > - Reviewed the PR > > > - Verified sha512 > > > - Checked github release tag > > > - Checked that the source code does not contain binaries > > > > > > Regards, > > > Jeyhun > > > > > > On Sat, Jun 8, 2024 at 1:52 PM weijie guo <guoweijieres...@gmail.com> > > > wrote: > > > > > > > Thanks Hong! > > > > > > > > +1(binding) > > > > > > > > - Verified gpg signature > > > > - Verified sha512 hash > > > > - Checked gh release tag > > > > - Checked all artifacts deployed to maven repo > > > > - Ran a simple wordcount job on local standalone cluster > > > > - Compiled from source code with JDK 1.8.0_291. > > > > > > > > Best regards, > > > > > > > > Weijie > > > > > > > > > > > > Xiqian YU <kono....@outlook.com> 于2024年6月7日周五 18:23写道： > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > > * Checked download links & release tags > > > > > * Verified that package checksums matched > > > > > * Compiled Flink from source code with JDK 8 / 11 > > > > > * Ran E2e data integration test jobs on local cluster > > > > > > > > > > Regards, > > > > > yux > > > > > > > > > > De : Rui Fan <1996fan...@gmail.com> > > > > > Date : vendredi, 7 juin 2024 à 17:14 > > > > > À : dev@flink.apache.org <dev@flink.apache.org> > > > > > Objet : Re: [VOTE] Release 1.19.1, release candidate #1 > > > > > +1(binding) > > > > > > > > > > - Reviewed the flink-web PR (Left some comments) > > > > > - Checked Github release tag > > > > > - Verified signatures > > > > > - Verified sha512 (hashsums) > > > > > - The source archives do not contain any binaries > > > > > - Build the source with Maven 3 and java8 (Checked the license as > > well) > > > > > - Start the cluster locally with jdk8, and run the > > StateMachineExample > > > > job, > > > > > it works fine. > > > > > > > > > > Best, > > > > > Rui > > > > > > > > > > On Thu, Jun 6, 2024 at 11:39 PM Hong Liang <h...@apache.org> > wrote: > > > > > > > > > > > Hi everyone, > > > > > > Please review and vote on the release candidate #1 for the flink > > > > v1.19.1, > > > > > > as follows: > > > > > > [ ] +1, Approve the release > > > > > > [ ] -1, Do not approve the release (please provide specific > > comments) > > > > > > > > > > > > > > > > > > The complete staging area is available for your review, which > > > includes: > > > > > > * JIRA release notes [1], > > > > > > * the official Apache source release and binary convenience > > releases > > > to > > > > > be > > > > > > deployed to dist.apache.org [2], which are signed with the key > > with > > > > > > fingerprint B78A5EA1 [3], > > > > > > * all artifacts to be deployed to the Maven Central Repository > [4], > > > > > > * source code tag "release-1.19.1-rc1" [5], > > > > > > * website pull request listing the new release and adding > > > announcement > > > > > blog > > > > > > post [6]. > > > > > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > > > majority > > > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > > > Thanks, > > > > > > Hong > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12354399 > > > > > > [2] > https://dist.apache.org/repos/dist/dev/flink/flink-1.19.1-rc1/ > > > > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > > [4] > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1736/ > > > > > > [5] > > https://github.com/apache/flink/releases/tag/release-1.19.1-rc1 > > > > > > [6] https://github.com/apache/flink-web/pull/745 > > > > > > > > > > > > > > > > > > > > >
