Thanks for driving this Sergey.

+1 (binding)

- Release notes look good
- Source archive checksum and signature is correct
- Binary checksum and signature is correct
- Contents of Maven repo looks good
- Verified there are no binaries in the source archive
- Builds from source using Java 8 (-Popensearch1)
- CI run passed
- Tag exists in repo
- NOTICE and LICENSE files present and correct

Thanks,
Danny

On Fri, Jun 7, 2024 at 4:27 AM Rui Fan <1996fan...@gmail.com> wrote:

> Thanks Sergey for the hard work!
>
> +1(binding)
>
> - Verified signatures
> - Verified sha512 (hashsums)
> - The source archives do not contain any binaries
> - Build the source with Maven 3 and java8 (Checked the license as well)
> - Checked Github release tag
> - Reviewed the flink-web PR
>
> Best,
> Rui
>
> On Thu, May 30, 2024 at 8:22 PM weijie guo <guoweijieres...@gmail.com>
> wrote:
>
> > Thanks Sergey for driving this release!
> >
> > +1(non-binding)
> >
> > 1. Verified signatures and hash sums
> > 2. Build from source with 1.8.0_291 succeeded
> > 3. Checked RN.
> >
> > Best regards,
> >
> > Weijie
> >
> >
> > Yuepeng Pan <panyuep...@apache.org> 于2024年5月30日周四 10:08写道:
> >
> > > +1 (non-binding)
> > >
> > > - Built from source code with JDK 1.8 on MaxOS- Run examples locally.-
> > > Checked release notes Best, Yuepeng Pan
> > >
> > >
> > > At 2024-05-28 22:53:10, "gongzhongqiang" <gongzhongqi...@apache.org>
> > > wrote:
> > > >+1(non-binding)
> > > >
> > > >- Verified signatures and hash sums
> > > >- Reviewed the web PR
> > > >- Built from source code with JDK 1.8 on Ubuntu 22.04
> > > >- Checked release notes
> > > >
> > > >Best,
> > > >Zhongqiang Gong
> > > >
> > > >
> > > >Sergey Nuyanzin <snuyan...@gmail.com> 于2024年5月16日周四 06:03写道:
> > > >
> > > >> Hi everyone,
> > > >> Please review and vote on release candidate #1 for
> > > >> flink-connector-opensearch v1.2.0, as follows:
> > > >> [ ] +1, Approve the release
> > > >> [ ] -1, Do not approve the release (please provide specific
> comments)
> > > >>
> > > >>
> > > >> The complete staging area is available for your review, which
> > includes:
> > > >> * JIRA release notes [1],
> > > >> * the official Apache source release to be deployed to
> > dist.apache.org
> > > >> [2],
> > > >> which are signed with the key with fingerprint
> > > >> F7529FAE24811A5C0DF3CA741596BBF0726835D8 [3],
> > > >> * all artifacts to be deployed to the Maven Central Repository [4],
> > > >> * source code tag v1.2.0-rc1 [5],
> > > >> * website pull request listing the new release [6].
> > > >> * CI build of the tag [7].
> > > >>
> > > >> The vote will be open for at least 72 hours. It is adopted by
> majority
> > > >> approval, with at least 3 PMC affirmative votes.
> > > >>
> > > >> Note that this release is for Opensearch v1.x
> > > >>
> > > >> Thanks,
> > > >> Release Manager
> > > >>
> > > >> [1] https://issues.apache.org/jira/projects/FLINK/versions/12353812
> > > >> [2]
> > > >>
> > > >>
> > >
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-opensearch-1.2.0-rc1
> > > >> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > >> [4]
> > > https://repository.apache.org/content/repositories/orgapacheflink-1734
> > > >> [5]
> > > >>
> > > >>
> > >
> >
> https://github.com/apache/flink-connector-opensearch/releases/tag/v1.2.0-rc1
> > > >> [6] https://github.com/apache/flink-web/pull/740
> > > >> [7]
> > > >>
> > > >>
> > >
> >
> https://github.com/apache/flink-connector-opensearch/actions/runs/9102334125
> > > >>
> > >
> >
>

Reply via email to