Thanks for driving this Sergey.

+1 (binding)

- Release notes look good
- Source archive checksum and signature is correct
- Binary checksum and signature is correct
- Contents of Maven repo looks good
- Verified there are no binaries in the source archive
- Builds from source using Java 11 (-Popensearch2)
- CI run passed
- Tag exists in repo
- NOTICE and LICENSE files present and correct

Thanks,
Danny

On Fri, Jun 7, 2024 at 4:17 AM Rui Fan <1996fan...@gmail.com> wrote:

> Thanks Sergey for the hard work!
>
> +1(binding)
>
> - Verified signatures
> - Verified sha512 (hashsums)
> - The source archives do not contain any binaries
> - Build the source with Maven 3 and java8 (Checked the license as well)
> - Checked Github release tag
> - Reviewed the flink-web PR
>
> Best,
> Rui
>
> On Mon, May 27, 2024 at 5:35 PM Hang Ruan <ruanhang1...@gmail.com> wrote:
>
> > +1 (non-binding)
> >
> > - verified signatures
> > - verified hashsums
> > - built from source code with JDK 11 succeed
> > - checked release notes
> > - reviewed the web PR
> >
> > Best,
> > Hang
> >
> > Leonard Xu <xbjt...@gmail.com> 于2024年5月22日周三 21:02写道:
> >
> > >
> > > > +1 (binding)
> > > >
> > > > - verified signatures
> > > > - verified hashsums
> > > > - built from source code with JDK 1.8 succeeded
> > > > - checked Github release tag
> > > > - checked release notes
> > > > - reviewed the web PR
> > >
> > > Supply more information about build from source code with JDK 1.8
> > >
> > > > - built from source code with JDK 1.8 succeeded
> > > It’s correct as we don’t activate opensearch2 profile by default.
> > >
> > > - built from source code with JDK 1.8 and -Popensearch2 failed
> > > - built from source code with JDK 11 and -Popensearch2 succeeded
> > >
> > > Best,
> > > Leonard
> > >
> > >
> > > >
> > > >
> > > >> 2024年5月16日 上午6:58,Andrey Redko <drr...@gmail.com> 写道:
> > > >>
> > > >> +1 (non-binding), thanks Sergey!
> > > >>
> > > >> On Wed, May 15, 2024, 6:00 p.m. Sergey Nuyanzin <
> snuyan...@gmail.com>
> > > wrote:
> > > >>
> > > >>> Hi everyone,
> > > >>> Please review and vote on release candidate #1 for
> > > >>> flink-connector-opensearch v2.0.0, as follows:
> > > >>> [ ] +1, Approve the release
> > > >>> [ ] -1, Do not approve the release (please provide specific
> comments)
> > > >>>
> > > >>>
> > > >>> The complete staging area is available for your review, which
> > includes:
> > > >>> * JIRA release notes [1],
> > > >>> * the official Apache source release to be deployed to
> > dist.apache.org
> > > >>> [2],
> > > >>> which are signed with the key with fingerprint
> > > >>> F7529FAE24811A5C0DF3CA741596BBF0726835D8 [3],
> > > >>> * all artifacts to be deployed to the Maven Central Repository [4],
> > > >>> * source code tag v2.0.0-rc1 [5],
> > > >>> * website pull request listing the new release [6].
> > > >>> * CI build of the tag [7].
> > > >>>
> > > >>> The vote will be open for at least 72 hours. It is adopted by
> > majority
> > > >>> approval, with at least 3 PMC affirmative votes.
> > > >>>
> > > >>> Note that this release is for Opensearch v2.x
> > > >>>
> > > >>> Thanks,
> > > >>> Release Manager
> > > >>>
> > > >>> [1]
> https://issues.apache.org/jira/projects/FLINK/versions/12354674
> > > >>> [2]
> > > >>>
> > > >>>
> > >
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-opensearch-2.0.0-rc1
> > > >>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > >>> [4]
> > > >>>
> > >
> https://repository.apache.org/content/repositories/orgapacheflink-1735/
> > > >>> [5]
> > > >>>
> > > >>>
> > >
> >
> https://github.com/apache/flink-connector-opensearch/releases/tag/v2.0.0-rc1
> > > >>> [6] https://github.com/apache/flink-web/pull/741
> > > >>> [7]
> > > >>>
> > > >>>
> > >
> >
> https://github.com/apache/flink-connector-opensearch/actions/runs/9102980808
> > > >>>
> > > >
> > >
> > >
> >
>

Reply via email to