After discuss with Ahmed, the updated FLIP looks good to me.
+1(binding) Best, Leonard > 2024年5月21日 下午6:12,Hong Liang <h...@apache.org> 写道: > > +1 (binding) > > Thanks Ahmed > > On Tue, May 14, 2024 at 11:51 AM David Radley <david_rad...@uk.ibm.com> > wrote: > >> Thanks for the clarification Ahmed >> >> +1 (non-binding) >> >> From: Ahmed Hamdy <hamdy10...@gmail.com> >> Date: Monday, 13 May 2024 at 19:58 >> To: dev@flink.apache.org <dev@flink.apache.org> >> Subject: [EXTERNAL] Re: [VOTE] FLIP-451: Introduce timeout configuration >> to AsyncSink >> Thanks David, >> I have replied to your question in the discussion thread. >> Best Regards >> Ahmed Hamdy >> >> >> On Mon, 13 May 2024 at 16:21, David Radley <david_rad...@uk.ibm.com> >> wrote: >> >>> Hi, >>> I raised a question on the discussion thread, around retriable errors, as >>> a possible alternative, >>> Kind regards, David. >>> >>> >>> From: Aleksandr Pilipenko <z3d...@gmail.com> >>> Date: Monday, 13 May 2024 at 16:07 >>> To: dev@flink.apache.org <dev@flink.apache.org> >>> Subject: [EXTERNAL] Re: [VOTE] FLIP-451: Introduce timeout configuration >>> to AsyncSink >>> Thanks for driving this! >>> >>> +1 (non-binding) >>> >>> Thanks, >>> Aleksandr >>> >>> On Mon, 13 May 2024 at 14:08, <lorenzo.affe...@ververica.com.invalid> >>> wrote: >>> >>>> Thanks Ahmed! >>>> >>>> +1 non binding >>>> On May 13, 2024 at 12:40 +0200, Jeyhun Karimov <je.kari...@gmail.com>, >>>> wrote: >>>>> Thanks for driving this Ahmed. >>>>> >>>>> +1 (non-binding) >>>>> >>>>> Regards, >>>>> Jeyhun >>>>> >>>>> On Mon, May 13, 2024 at 12:37 PM Muhammet Orazov >>>>> <mor+fl...@morazow.com.invalid> wrote: >>>>> >>>>>> Thanks Ahmed, +1 (non-binding) >>>>>> >>>>>> Best, >>>>>> Muhammet >>>>>> >>>>>> On 2024-05-13 09:50, Ahmed Hamdy wrote: >>>>>>>> Hi all, >>>>>>>> >>>>>>>> Thanks for the feedback on the discussion thread[1], I would >> like >>>> to >>>>>>>> start >>>>>>>> a vote on FLIP-451[2]: Introduce timeout configuration to >>> AsyncSink >>>>>>>> >>>>>>>> The vote will be open for at least 72 hours unless there is an >>>>>>>> objection or >>>>>>>> insufficient votes. >>>>>>>> >>>>>>>> 1- >>> https://lists.apache.org/thread/ft7wcw7kyftvww25n5fm4l925tlgdfg0 >>>>>>>> 2- >>>>>>>> >>>>>> >>>> >>> >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-451%3A+Introduce+timeout+configuration+to+AsyncSink+API >>>>>>>> Best Regards >>>>>>>> Ahmed Hamdy >>>>>> >>>> >>> >>> Unless otherwise stated above: >>> >>> IBM United Kingdom Limited >>> Registered in England and Wales with number 741598 >>> Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU >>> >> >> Unless otherwise stated above: >> >> IBM United Kingdom Limited >> Registered in England and Wales with number 741598 >> Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU >>