Thanks for the feedback Jeyhun. Regarding Will the usage of Conditions be enabled by default? Or will there be any disadvantages for Flink users . Yes the conditions will be enabled by default for the CR.
You are right , when there are multiple conditions of the same type, approach is we will override the old condition with new conditions only if conditions status and messages are the same. If they are different , we will add to existing conditions. Thanks Lajith On Fri, May 3, 2024 at 8:05 PM Jeyhun Karimov <je.kari...@gmail.com> wrote: > Hi Lajith, > > Thanks a lot for driving this FLIP. Please find my comments below: > > - I echo Gyula that including some examples and further explanations might > ease reader's work. With the current version, the FLIP is a bit hard to > follow. > > - Will the usage of Conditions be enabled by default? Or will there be any > disadvantages for Flink users? > > If Conditions with the same type already exist in the Status Conditions > > list, then replace the existing condition with the same type if the > > Condition status and message are different. > > - Do you think we should have clear rules about handling rules for how > these Conditions should be managed, especially when multiple Conditions of > the same type are present? > For example, resource has multiple causes for the same condition (e.g., > Error due to network and Error due to I/O). Then, overriding the old > condition with the new one is not the best approach no? > Please correct me if I misunderstood. > > Regards, > Jeyhun > > On Fri, May 3, 2024 at 8:53 AM Gyula Fóra <gyula.f...@gmail.com> wrote: > > > Hi Lajith! > > > > Can you please include some examples in the document to help reviewers? > > Just some examples with the status and the proposed conditions. > > > > Cheers, > > Gyula > > > > On Wed, May 1, 2024 at 9:06 AM Lajith Koova <lajith...@gmail.com> wrote: > > > > > Hello, > > > > > > > > > Starting discussion thread here to discuss a proposal to add Conditions > > > field in the CR status of Flink Deployment and FlinkSessionJob. > > > > > > > > > Here is the google doc with details. Please provide your > thoughts/inputs. > > > > > > > > > > > > > > > https://docs.google.com/document/d/12wlJCL_Vq2KZnABzK7OR7gAd1jZMmo0MxgXQXqtWODs/edit?usp=sharing > > > > > > > > > Thanks > > > Lajith > > > > > >
