-1 (binding) There is a bug [1] in the connector release utils resulting in the build tools [2] not being copied into the source archive. As a result the source archive fails build due to checkstyle errors.
This vote is now closed, I will follow up with an RC2. Thanks, Danny [1] https://issues.apache.org/jira/browse/FLINK-35124 [2] https://github.com/apache/flink-connector-jdbc/tree/main/tools On Wed, Apr 17, 2024 at 2:31 PM Jeyhun Karimov <je.kari...@gmail.com> wrote: > Thanks for driving this. > > +1 (non-binding) > > - Validated checksum hash > - Verified signature > - Tag is present > - Reviewed web PR > > Regards, > Jeyhun > > On Wed, Apr 17, 2024 at 3:26 PM gongzhongqiang <gongzhongqi...@apache.org> > wrote: > > > +1 (non-binding) > > > > - Flink website pr reviewed > > - Check source code without binary files > > - Validated checksum hash and signature > > - CI passed with tag v1.2.0-rc1 > > > > Best, > > Zhongqiang Gong > > > > Danny Cranmer <dannycran...@apache.org> 于2024年4月17日周三 18:44写道： > > > > > Hi everyone, > > > > > > Please review and vote on the release candidate #1 for v1.2.0, as > > follows: > > > [ ] +1, Approve the release > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > This release supports Flink 1.18 and 1.19. > > > > > > The complete staging area is available for your review, which includes: > > > * JIRA release notes [1], > > > * the official Apache source release to be deployed to dist.apache.org > > > [2], > > > which are signed with the key with fingerprint 125FD8DB [3], > > > * all artifacts to be deployed to the Maven Central Repository [4], > > > * source code tag v1.2.0-rc1 [5], > > > * website pull request listing the new release [6]. > > > * CI build of tag [7]. > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > approval, with at least 3 PMC affirmative votes. > > > > > > Thanks, > > > Danny > > > > > > [1] > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12354192 > > > [2] > > > > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-mongodb-1.2.0-rc1 > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > [4] > > > > https://repository.apache.org/content/repositories/orgapacheflink-1715/ > > > [5] > > > > > > https://github.com/apache/flink-connector-mongodb/releases/tag/v1.2.0-rc1 > > > [6] https://github.com/apache/flink-web/pull/735 > > > [7] > > > > > > https://github.com/apache/flink-connector-mongodb/actions/runs/8720057880 > > > > > >
