Hi Xuannan, > Regarding the new classes, we propose updating the > `ConfigOptionsDocGenerator` to throw an exception and fail the build > if it detects any new class missing the proper annotation in the > future.
Thanks for your feedback, it sounds good to me. Best, Rui On Fri, Apr 12, 2024 at 9:35 AM Xuannan Su <suxuanna...@gmail.com> wrote: > Hi Rui, > > If I understand correctly, all classes without annotations are > non-public by default. I'm concerned that adding an exception to this > rule will make it harder to understand. > > Regarding the new classes, we propose updating the > `ConfigOptionsDocGenerator` to throw an exception and fail the build > if it detects any new class missing the proper annotation in the > future. > > Best regards, > Xuannan > > > On Wed, Apr 10, 2024 at 2:09 PM Rui Fan <1996fan...@gmail.com> wrote: > > > > Thanks Xuannan for driving this proposal! > > > > > Ensure all the ConfigOptions are properly annotated as PublicEvolving > > > > Could we add a specification directly? All XxxOptions classes are > > PublicEvolving by default. I'm afraid some new classes still miss > > PublicEvolving in the future. > > > > If we have a specification, it will be clear. And we don't need to > > add PublicEvolving for each XxxOptions. > > > > Best, > > Rui > > > > On Wed, Apr 10, 2024 at 1:54 PM Muhammet Orazov > <mor+fl...@morazow.com.invalid> wrote: > >> > >> Hey Xuannan, > >> > >> Thanks for the FLIP and your efforts! > >> > >> Minor clarification from my side: > >> > >> > We will relocate these ConfigOptions to a class that is included > >> > in the documentation generation. > >> > >> Would it make sense to define also in the FLIP the options class for > >> these variables? For example, GPUDriverOptions? > >> > >> Best, > >> Muhammet > >> > >> On 2024-04-09 08:20, Xuannan Su wrote: > >> > Hi all, > >> > > >> > I'd like to start a discussion on FLIP-442: General Improvement to > >> > Configuration for Flink 2.0 [1]. As Flink moves toward 2.0, we aim to > >> > provide users with a better experience with the existing > >> > configuration. This FLIP proposes several general improvements to the > >> > current configuration. > >> > > >> > Looking forward to everyone's feedback and suggestions. Thank you! > >> > > >> > Best regards, > >> > Xuannan > >> > > >> > [1] > >> > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-442%3A+General+Improvement+to+Configuration+for+Flink+2.0 >
