Thanks for driving this, Etienne! +1 (non-binding)
- Verified checksum and signature - Verified pom - Built from source - Verified no binaries - Checked staging repo on Maven central - Checked source code tag - Reviewed web PR One thing (probably minor) I noticed that the artifacts (uploaded to nexus) are built with jdk11 while usually it should be with jdk8 Since there is no jars I think it should be ok On Tue, Feb 20, 2024 at 9:19 AM Hang Ruan <ruanhang1...@gmail.com> wrote: > +1 (non-binding) > > - verified checksum and signature > - checked Github release tag > - checked release notes > - verified no binaries in source > - reviewed the web PR > > Best, > Hang > > Leonard Xu <xbjt...@gmail.com> 于2024年2月20日周二 14:26写道： > > > +1 (binding) > > > > - verified signatures > > - verified hashsums > > - built from source code succeeded > > - checked Github release tag > > - checked release notes > > - reviewed all Jira tickets have been resolved > > - reviewed the web PR > > > > Best, > > Leonard > > > > > > > 2024年2月20日 上午11:14，Rui Fan <1996fan...@gmail.com> 写道： > > > > > > Thanks for driving this, Etienne! > > > > > > +1 (non-binding) > > > > > > - Verified checksum and signature > > > - Verified pom content > > > - Build source on my Mac with jdk8 > > > - Verified no binaries in source > > > - Checked staging repo on Maven central > > > - Checked source code tag > > > - Reviewed web PR > > > > > > Best, > > > Rui > > > > > > On Tue, Feb 20, 2024 at 10:33 AM Qingsheng Ren <re...@apache.org> > wrote: > > > > > >> Thanks for driving this, Etienne! > > >> > > >> +1 (binding) > > >> > > >> - Checked release note > > >> - Verified checksum and signature > > >> - Verified pom content > > >> - Verified no binaries in source > > >> - Checked staging repo on Maven central > > >> - Checked source code tag > > >> - Reviewed web PR > > >> - Built Kafka connector from source with parent pom in staging repo > > >> > > >> Best, > > >> Qingsheng > > >> > > >> On Tue, Feb 20, 2024 at 1:34 AM Etienne Chauchot < > echauc...@apache.org> > > >> wrote: > > >> > > >>> Hi everyone, > > >>> Please review and vote on the release candidate #2 for the version > > >>> 1.1.0, as follows: > > >>> [ ] +1, Approve the release > > >>> [ ] -1, Do not approve the release (please provide specific comments) > > >>> > > >>> > > >>> The complete staging area is available for your review, which > includes: > > >>> * JIRA release notes [1], > > >>> * the official Apache source release to be deployed to > dist.apache.org > > >>> [2], which are signed with the key with fingerprint > > >>> D1A76BA19D6294DD0033F6843A019F0B8DD163EA [3], > > >>> * all artifacts to be deployed to the Maven Central Repository [4], > > >>> * source code tag v1.1.0-rc2 [5], > > >>> * website pull request listing the new release [6]. > > >>> > > >>> * confluence wiki: connector parent upgrade to version 1.1.0 that > will > > >>> be validated after the artifact is released (there is no PR mechanism > > on > > >>> the wiki) [7] > > >>> > > >>> > > >>> The vote will be open for at least 72 hours. It is adopted by > majority > > >>> approval, with at least 3 PMC affirmative votes. > > >>> > > >>> Thanks, > > >>> Etienne > > >>> > > >>> [1] > > >>> > > >>> > > >> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353442 > > >>> [2] > > >>> > > >>> > > >> > > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc2 > > >>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > >>> [4] > > >> > https://repository.apache.org/content/repositories/orgapacheflink-1707 > > >>> [5] > > >>> > > >>> > > >> > > > https://github.com/apache/flink-connector-shared-utils/releases/tag/v1.1.0-rc2 > > >>> > > >>> [6] https://github.com/apache/flink-web/pull/717 > > >>> > > >>> [7] > > >>> > > >>> > > >> > > > https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development > > >>> > > >> > > > > > -- Best regards, Sergey
