+1 (binding) - Inspected source release (checked license, headers, no binaries) - Verified checksums and signature
Cheers, Max On Sun, Feb 4, 2024 at 5:41 AM Qingsheng Ren <re...@apache.org> wrote: > > Thanks for driving this, Martijn! > > +1 (binding) > > - Verified checksum and signature > - Verified no binaries in source > - Built from source with Java 8 > - Reviewed web PRs > - Run a Flink SQL job reading and writing Kafka on 1.18.1 cluster. Results > are as expected. > > Best, > Qingsheng > > On Tue, Jan 30, 2024 at 3:50 PM Mason Chen <mas.chen6...@gmail.com> wrote: > > > +1 (non-binding) > > > > * Verified LICENSE and NOTICE files (this RC has a NOTICE file that points > > to 2023 that has since been updated on the main branch by Hang) > > * Verified hashes and signatures > > * Verified no binaries > > * Verified poms point to 3.1.0 > > * Reviewed web PR > > * Built from source > > * Verified git tag > > > > In the same vein as the web PR, do we want to prepare the PR to update the > > shortcode in the connector docs now [1]? Same for the Chinese version. I > > wonder if that should be included in the connector release instructions. > > > > [1] > > > > https://github.com/apache/flink-connector-kafka/blob/d89a082180232bb79e3c764228c4e7dbb9eb6b8b/docs/content/docs/connectors/datastream/kafka.md#L39 > > > > Best, > > Mason > > > > On Sun, Jan 28, 2024 at 11:41 PM Hang Ruan <ruanhang1...@gmail.com> wrote: > > > > > +1 (non-binding) > > > > > > - Validated checksum hash > > > - Verified signature > > > - Verified that no binaries exist in the source archive > > > - Build the source with Maven and jdk11 > > > - Verified web PR > > > - Check that the jar is built by jdk8 > > > > > > Best, > > > Hang > > > > > > Martijn Visser <martijnvis...@apache.org> 于2024年1月26日周五 21:05写道： > > > > > > > Hi everyone, > > > > Please review and vote on the release candidate #1 for the Flink Kafka > > > > connector version 3.1.0, as follows: > > > > [ ] +1, Approve the release > > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > > > This release is compatible with Flink 1.17.* and Flink 1.18.* > > > > > > > > The complete staging area is available for your review, which includes: > > > > * JIRA release notes [1], > > > > * the official Apache source release to be deployed to dist.apache.org > > > > [2], > > > > which are signed with the key with fingerprint > > > > A5F3BCE4CBE993573EC5966A65321B8382B219AF [3], > > > > * all artifacts to be deployed to the Maven Central Repository [4], > > > > * source code tag v3.1.0-rc1 [5], > > > > * website pull request listing the new release [6]. > > > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > Thanks, > > > > Release Manager > > > > > > > > [1] > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353135 > > > > [2] > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.1.0-rc1 > > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > [4] > > > https://repository.apache.org/content/repositories/orgapacheflink-1700 > > > > [5] > > > > > > https://github.com/apache/flink-connector-kafka/releases/tag/v3.1.0-rc1 > > > > [6] https://github.com/apache/flink-web/pull/718 > > > > > > > > >
