Thanks to Xintong for clarifying this! @Rui Due to the rules of feature freeze: "Only bug fixes and documentation changes are allowed."[1], your merge request has been discussed among 1.19 RMs, we also agree that do not merge these PRs which are purely cleanup work and no more benefits for users. Thank you for agreeing.
Also update the progress: *- Cutting release branch* We're still working on two blockers[2][3], we'll decide when to cut 1.19 release branch after next release sync(Feb 6th) discussion [1] https://cwiki.apache.org/confluence/display/FLINK/Flink+Release+Management [2] https://issues.apache.org/jira/browse/FLINK-34337 [3] https://issues.apache.org/jira/browse/FLINK-34007 Best, Yun, Jing, Martijn and Lincoln Rui Fan <1996fan...@gmail.com> 于2024年2月5日周一 13:42写道： > > My opinion would be to follow the process by default, and to make > exceptions only if there're good reasons. > > Sounds make sense, I will merge it after 1.19 branch cutting. > > Thanks Xintong for the explanation! And sorry for bothering. > > Best, > Rui > > On Mon, Feb 5, 2024 at 1:20 PM Xintong Song <tonysong...@gmail.com> wrote: > > > Thanks for the info. > > > > My opinion would be to follow the process by default, and to make > > exceptions only if there're good reasons. From your description, it > sounds > > like merging the PR in or after 1.19 doesn't really make a difference. In > > that case, I'd suggest to merge it for the next release (i.e. merge it > into > > master after the 1.19 branch cutting). > > > > Best, > > > > Xintong > > > > > > > > On Mon, Feb 5, 2024 at 12:52 PM Rui Fan <1996fan...@gmail.com> wrote: > > > > > Thanks Xintong for the reply. > > > > > > They are Flink internal classes, and they are not used anymore. > > > So I think they don't affect users, the benefit of removing them > > > is to simplify Flink's code and reduce maintenance costs. > > > > > > If we just merge some user-related PRs recently, I could merge > > > it after 1.19. Thank you again~ > > > > > > Best, > > > Rui > > > > > > On Mon, Feb 5, 2024 at 12:21 PM Xintong Song <tonysong...@gmail.com> > > > wrote: > > > > > > > Hi Rui, > > > > > > > > Quick question, would there be any downside if this PR doesn't go > into > > > > 1.19? Or any user benefit from getting it into this release? > > > > > > > > Best, > > > > > > > > Xintong > > > > > > > > > > > > > > > > On Sun, Feb 4, 2024 at 10:16 AM Rui Fan <1996fan...@gmail.com> > wrote: > > > > > > > > > Hi release managers, > > > > > > > > > > > The feature freeze of 1.19 has started now. That means that no > new > > > > > features > > > > > > or improvements should now be merged into the master branch > unless > > > you > > > > > ask > > > > > > the release managers first, which has already been done for PRs, > or > > > > > pending > > > > > > on CI to pass. Bug fixes and documentation PRs can still be > merged. > > > > > > > > > > I'm curious whether the code cleanup could be merged? > > > > > FLINK-31449[1] removed DeclarativeSlotManager related logic. > > > > > Some other classes are not used anymore after FLINK-31449. > > > > > FLINK-34345[2][3] will remove them. > > > > > > > > > > I checked these classes are not used in the master branch. > > > > > And the PR[3] is reviewed for now, could I merge it now or > > > > > after flink-1.19? > > > > > > > > > > Looking forward to your feedback, thanks~ > > > > > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-31449 > > > > > [2] https://issues.apache.org/jira/browse/FLINK-34345 > > > > > [3] https://github.com/apache/flink/pull/24257 > > > > > > > > > > Best, > > > > > Rui > > > > > > > > > > On Wed, Jan 31, 2024 at 5:20 PM Lincoln Lee < > lincoln.8...@gmail.com> > > > > > wrote: > > > > > > > > > >> Hi Matthias, > > > > >> > > > > >> Thanks for letting us know! After discussed with 1.19 release > > > managers, > > > > we > > > > >> agreed to merge these pr. > > > > >> > > > > >> Thank you for the work on GHA workflows! > > > > >> > > > > >> Best, > > > > >> Yun, Jing, Martijn and Lincoln > > > > >> > > > > >> > > > > >> Matthias Pohl <matthias.p...@aiven.io> 于2024年1月30日周二 22:20写道： > > > > >> > > > > >> > Thanks for the update, Lincoln. > > > > >> > > > > > >> > fyi: I merged FLINK-32684 (deprecating AkkaOptions) [1] since we > > > > agreed > > > > >> in > > > > >> > today's meeting that this change is still ok to go in. > > > > >> > > > > > >> > The beta version of the GitHub Actions workflows (FLIP-396 [2]) > > are > > > > also > > > > >> > finalized (see related PRs for basic CI [3], nightly master [4] > > and > > > > >> nightly > > > > >> > scheduling [5]). I'd like to merge the changes before creating > the > > > > >> > release-1.19 branch. That would enable us to see whether we miss > > > > >> anything > > > > >> > in the GHA workflows setup when creating a new release branch. > > > > >> > > > > > >> > The changes are limited to a few CI scripts that are also used > for > > > > Azure > > > > >> > Pipelines (see [3]). The majority of the changes are > GHA-specific > > > and > > > > >> > shouldn't affect the Azure Pipelines CI setup. > > > > >> > > > > > >> > Therefore, I'm requesting the approval from the 1.19 release > > > managers > > > > to > > > > >> > go ahead with merging the mentioned PRs [3, 4, 5]. > > > > >> > > > > > >> > Matthias > > > > >> > > > > > >> > > > > > >> > [1] https://issues.apache.org/jira/browse/FLINK-32684 > > > > >> > [2] > > > > >> > > > > > >> > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-396%3A+Trial+to+test+GitHub+Actions+as+an+alternative+for+Flink%27s+current+Azure+CI+infrastructure > > > > >> > [3] https://github.com/apache/flink/pull/23970 > > > > >> > [4] https://github.com/apache/flink/pull/23971 > > > > >> > [5] https://github.com/apache/flink/pull/23972 > > > > >> > > > > > >> > On Tue, Jan 30, 2024 at 1:51 PM Lincoln Lee < > > lincoln.8...@gmail.com > > > > > > > > >> > wrote: > > > > >> > > > > > >> >> Hi everyone, > > > > >> >> > > > > >> >> (Since feature freeze and release sync are on the same day, we > > > merged > > > > >> the > > > > >> >> announcement and sync summary together) > > > > >> >> > > > > >> >> > > > > >> >> *- Feature freeze* > > > > >> >> The feature freeze of 1.19 has started now. That means that no > > new > > > > >> >> features > > > > >> >> or improvements should now be merged into the master branch > > unless > > > > you > > > > >> ask > > > > >> >> the release managers first, which has already been done for > PRs, > > or > > > > >> >> pending > > > > >> >> on CI to pass. Bug fixes and documentation PRs can still be > > merged. > > > > >> >> > > > > >> >> > > > > >> >> *- Cutting release branch* > > > > >> >> Currently we have three blocker issues[1][2][3], and will try > to > > > > close > > > > >> >> them this Friday. > > > > >> >> We are planning to cut the release branch on next Monday (Feb > > 6th) > > > if > > > > >> no > > > > >> >> new test instabilities, > > > > >> >> and we'll make another announcement in the dev mailing list > then. > > > > >> >> > > > > >> >> > > > > >> >> *- Cross-team testing* > > > > >> >> Release testing is expected to start next week as soon as we > cut > > > the > > > > >> >> release branch. > > > > >> >> As a prerequisite, please Before we start testing, please make > > sure > > > > >> >> 1. Whether the feature needs a cross-team testing > > > > >> >> 2. If yes, please the documentation completed > > > > >> >> There's an umbrella ticket[4] for tracking the 1.19 testing, RM > > > will > > > > >> >> create all tickets for completed features listed on the 1.19 > wiki > > > > >> page[5] > > > > >> >> and assign to the feature's Responsible Contributor, > > > > >> >> also contributors are encouraged to create tickets following > the > > > > steps > > > > >> in > > > > >> >> the umbrella ticket if there are other ones that need to be > > > > cross-team > > > > >> >> tested. > > > > >> >> > > > > >> >> *- Release notes* > > > > >> >> > > > > >> >> All new features and behavior changes require authors to fill > out > > > the > > > > >> >> 'Release Note' column in the JIRA(click the Edit button and > pull > > > the > > > > >> page > > > > >> >> to the center), > > > > >> >> especially since 1.19 involves a lot of deprecation, which is > > > > important > > > > >> >> for users and will be part of the release announcement. > > > > >> >> > > > > >> >> - *Sync meeting* (https://meet.google.com/vcx-arzs-trv) > > > > >> >> > > > > >> >> We've already switched to weekly release sync, so the next > > release > > > > sync > > > > >> >> will be on Feb 6th, 2024. Feel free to join us! > > > > >> >> > > > > >> >> [1] https://issues.apache.org/jira/browse/FLINK-34148 > > > > >> >> [2] https://issues.apache.org/jira/browse/FLINK-34007 > > > > >> >> [3] https://issues.apache.org/jira/browse/FLINK-34259 > > > > >> >> [4] https://issues.apache.org/jira/browse/FLINK-34285 > > > > >> >> [5] > > https://cwiki.apache.org/confluence/display/FLINK/1.19+Release > > > > >> >> > > > > >> >> Best, > > > > >> >> Yun, Jing, Martijn and Lincoln > > > > >> >> > > > > >> > > > > > >> > > > > > > > > > > > > > > >
