Hi Jinzhong, Thanks for driving this! +1 for fixing the lack of annotation.
I'm wondering if we really need to annotate *RocksDBStateUploader* and *RocksDBStateDownloader *with @Internal, as they seem to be ordinary classes without interacting with other modules. Also, I have reservations about annotating *SingleStateIterator*, but I'd like to hear others' opinions and won't insist on this. Best, Zakelly On Wed, Jan 24, 2024 at 10:26 PM Jinzhong Li <lijinzhong2...@gmail.com> wrote: > Hi devs, > > I’m opening this thread to discuss about FLIP-420: Add API annotations for > RocksDB StateBackend user-facing classes[1]. > > As described in FLINK-18255[2] , several user-facing classes in > flink-statebackend-rocksdb module don't have any API annotations, not even > @PublicEvolving. This FLIP will add annotations for them to clarify their > usage. > > Looking forward to hearing from you, thanks! > > > Best regards, > Jinzhong Li > > > [1] > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-420%3A+Add+API+annotations+for+RocksDB+StateBackend+user-facing+classes > [2] https://issues.apache.org/jira/browse/FLINK-18255 >
