Thanks for the last minute change.
+1 (binding)
Cheers,
Timo
On 05.01.24 08:59, Feng Jin wrote:
Hi Timo,
Thank you for the suggestion. Previously, I thought most parameters were
optional, so the default value was set to true.
Your concern is reasonable. We should declare it as false by default and
developers should explicitly state if a parameter is optional instead of
using our default value.
Regarding this part, I have already made modifications in the document.
Best,
Feng
On Fri, Jan 5, 2024 at 3:38 PM Timo Walther <twal...@apache.org> wrote:
Thanks, for starting the VOTE thread and thanks for considering my
feedback. One last comment before I'm also happy to give my +1 to this:
Why is ArgumentHint's default isOptinal=true? Shouldn't it be false by
default? Many function implementers will forget to set this to false and
suddenly get NULLs passed to their functions. Marking an argument as
optional should be an explicit decision of an implementer.
Regards,
Timo
On 05.01.24 05:06, Lincoln Lee wrote:
+1 (binding)
Best,
Lincoln Lee
Benchao Li <libenc...@apache.org> 于2024年1月5日周五 11:46写道：
+1 (binding)
Feng Jin <jinfeng1...@gmail.com> 于2024年1月5日周五 10:49写道：
Hi everyone
Thanks for all the feedback about the FLIP-387: Support named
parameters
for functions and call procedures [1] [2] .
I'd like to start a vote for it. The vote will be open for at least 72
hours(excluding weekends,until Jan 10, 12:00AM GMT) unless there is an
objection or an insufficient number of votes.
[1]
https://cwiki.apache.org/confluence/display/FLINK/FLIP-387%3A+Support+named+parameters+for+functions+and+call+procedures
[2] https://lists.apache.org/thread/bto7mpjvcx7d7k86owb00dwrm65jx8cn
Best,
Feng Jin
--
Best,
Benchao Li
