Hi Xiangyu, The proposed new options are targeted on experienced Flink platform administrators instead of normal end users, and a one-by-one mapping from non-default option to the default option variant might be easier for users to understand. Also, although JM and TM tend to use the same set of JVM args in most times, there're cases where different set of JVM args are preferable. So I am leaning towards the current design, WDYT?
Best, Zhanghao Chen ________________________________ From: xiangyu feng <xiangyu...@gmail.com> Sent: Friday, December 29, 2023 20:20 To: dev@flink.apache.org <dev@flink.apache.org> Subject: Re: [DISCUSS] FLIP-397: Add config options for administrator JVM options Hi Zhanghao, Thanks for driving this. +1 for the overall idea. One minor question, do we need separate administrator JVM options for both JobManager and TaskManager? Or just one administrator JVM option for all? I'm afraid of 6 jvm options(env.java.opts.all\env.java.default-opts.all\env.java.opts.jobmanager\env.java.default-opts.jobmanager\env.java.opts.taskmanager\env.java.default-opts.taskmanager) may confuse users. Regards, Xiangyu Yong Fang <zjur...@gmail.com> 于2023年12月27日周三 15:36写道： > +1 for this, we have met jobs that need to set GC policies different from > the default ones to improve performance. Separating the default and > user-set ones can help us better manage them. > > Best, > Fang Yong > > On Fri, Dec 22, 2023 at 9:18 PM Benchao Li <libenc...@apache.org> wrote: > > > +1 from my side, > > > > I also met some scenarios that I wanted to set some JVM options by > > default for all Flink jobs before, such as > > '-XX:-DontCompileHugeMethods', without it, some generated big methods > > won't be optimized in JVM C2 compiler, leading to poor performance. > > > > Zhanghao Chen <zhanghao.c...@outlook.com> 于2023年11月27日周一 20:04写道： > > > > > > Hi devs, > > > > > > I'd like to start a discussion on FLIP-397: Add config options for > > administrator JVM options [1]. > > > > > > In production environments, users typically develop and operate their > > Flink jobs through a managed platform. Users may need to add JVM options > to > > their Flink applications (e.g. to tune GC options). They typically use > the > > env.java.opts.x series of options to do so. Platform administrators also > > have a set of JVM options to apply by default, e.g. to use JVM 17, enable > > GC logging, or apply pretuned GC options, etc. Both use cases will need > to > > set the same series of options and will clobber one another. Similar > issues > > have been described in SPARK-23472 [2]. > > > > > > Therefore, I propose adding a set of default JVM options for > > administrator use that prepends the user-set extra JVM options. > > > > > > Looking forward to hearing from you. > > > > > > [1] > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-397%3A+Add+config+options+for+administrator+JVM+options > > > [2] https://issues.apache.org/jira/browse/SPARK-23472 > > > > > > Best, > > > Zhanghao Chen > > > > > > > > -- > > > > Best, > > Benchao Li > > >
