Hi, +1 (binding)
- Validated hashes - Verified signature - Verified that no binaries exist in the source archive - Build the source with Maven - Verified licenses - Verified web PRs Best regards, Martijn On Mon, Dec 11, 2023 at 12:11 AM Sergey Nuyanzin <snuyan...@gmail.com> wrote: > > Hey everyone, > > The vote for flink-shaded 18.0 is still open. Please test and vote for > rc1, so that we can release it. > > On Thu, Nov 30, 2023 at 4:03 PM Jing Ge <j...@ververica.com.invalid> wrote: > > > +1(not binding) > > > > - validate checksum > > - validate hash > > - checked the release notes > > - verified that no binaries exist in the source archive > > - build the source with Maven 3.8.6 and jdk11 > > - checked repo > > - checked tag > > - verified web PR > > > > Best regards, > > Jing > > > > On Thu, Nov 30, 2023 at 11:39 AM Sergey Nuyanzin <snuyan...@gmail.com> > > wrote: > > > > > +1 (non-binding) > > > > > > - Downloaded all the resources > > > - Validated checksum hash > > > - Build the source with Maven and jdk8 > > > - Build Flink master with new flink-shaded and check that all the tests > > are > > > passing > > > > > > one minor thing that I noticed during releasing: for ci it uses maven > > 3.8.6 > > > at the same time for release profile there is an enforcement plugin to > > > check that maven version is less than 3.3 > > > I created a jira issue[1] for that > > > i made the release with 3.2.5 maven version (I suppose previous version > > was > > > also done with 3.2.5 because of same issue) > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-33703 > > > > > > On Wed, Nov 29, 2023 at 11:41 AM Matthias Pohl <matthias.p...@aiven.io> > > > wrote: > > > > > > > +1 (binding) > > > > > > > > * Downloaded all resources > > > > * Extracts sources and compilation on these sources > > > > * Diff of git tag checkout with downloaded sources > > > > * Verifies SHA512 checksums & GPG certification > > > > * Checks that all POMs have the right expected version > > > > * Generated diffs to compare pom file changes with NOTICE files: > > Nothing > > > > suspicious found except for a minor (non-blocking) typo [1] > > > > > > > > Thanks for driving this effort, Sergey. :) > > > > > > > > [1] https://github.com/apache/flink-shaded/pull/126/files#r1409080162 > > > > > > > > On Wed, Nov 29, 2023 at 10:25 AM Rui Fan <1996fan...@gmail.com> wrote: > > > > > > > >> Sorry, it's non-binding. > > > >> > > > >> On Wed, Nov 29, 2023 at 5:19 PM Rui Fan <1996fan...@gmail.com> wrote: > > > >> > > > >> > Thanks Matthias for the clarification! > > > >> > > > > >> > After I import the latest KEYS, it works fine. > > > >> > > > > >> > +1(binding) > > > >> > > > > >> > - Validated checksum hash > > > >> > - Verified signature > > > >> > - Verified that no binaries exist in the source archive > > > >> > - Build the source with Maven and jdk8 > > > >> > - Verified licenses > > > >> > - Verified web PRs, and left a comment > > > >> > > > > >> > Best, > > > >> > Rui > > > >> > > > > >> > On Wed, Nov 29, 2023 at 5:05 PM Matthias Pohl > > > >> > <matthias.p...@aiven.io.invalid> wrote: > > > >> > > > > >> >> The key is the last key in the KEYS file. It's just having a > > > different > > > >> >> format with spaces being added (due to different gpg versions?): > > F752 > > > >> 9FAE > > > >> >> 2481 1A5C 0DF3 CA74 1596 BBF0 7268 35D8 > > > >> >> > > > >> >> On Wed, Nov 29, 2023 at 9:41 AM Rui Fan <1996fan...@gmail.com> > > > wrote: > > > >> >> > > > >> >> > Hey Sergey, > > > >> >> > > > > >> >> > Thank you for driving this release. > > > >> >> > > > > >> >> > I try to check this signature, the whole key is > > > >> >> > F7529FAE24811A5C0DF3CA741596BBF0726835D8, > > > >> >> > it matches your 1596BBF0726835D8, but I cannot > > > >> >> > find it from the Flink KEYS[1]. > > > >> >> > > > > >> >> > Please correct me if my operation is wrong, thanks~ > > > >> >> > > > > >> >> > [1] https://dist.apache.org/repos/dist/release/flink/KEYS > > > >> >> > > > > >> >> > Best, > > > >> >> > Rui > > > >> >> > > > > >> >> > > > > >> >> > On Wed, Nov 29, 2023 at 6:09 AM Sergey Nuyanzin < > > > snuyan...@gmail.com > > > >> > > > > >> >> > wrote: > > > >> >> > > > > >> >> > > Hi everyone, > > > >> >> > > Please review and vote on the release candidate #1 for the > > > version > > > >> >> 18.0, > > > >> >> > as > > > >> >> > > follows: > > > >> >> > > [ ] +1, Approve the release > > > >> >> > > [ ] -1, Do not approve the release (please provide specific > > > >> comments) > > > >> >> > > > > > >> >> > > > > > >> >> > > The complete staging area is available for your review, which > > > >> >> includes: > > > >> >> > > * JIRA release notes [1], > > > >> >> > > * the official Apache source release to be deployed to > > > >> >> dist.apache.org > > > >> >> > > [2], > > > >> >> > > which are signed with the key with fingerprint 1596BBF0726835D8 > > > >> [3], > > > >> >> > > * all artifacts to be deployed to the Maven Central Repository > > > [4], > > > >> >> > > * source code tag "release-18.0-rc1" [5], > > > >> >> > > * website pull request listing the new release [6]. > > > >> >> > > > > > >> >> > > The vote will be open for at least 72 hours. It is adopted by > > > >> majority > > > >> >> > > approval, with at least 3 PMC affirmative votes. > > > >> >> > > > > > >> >> > > Thanks, > > > >> >> > > Sergey > > > >> >> > > > > > >> >> > > [1] > > > >> https://issues.apache.org/jira/projects/FLINK/versions/12353081 > > > >> >> > > [2] > > > >> >> https://dist.apache.org/repos/dist/dev/flink/flink-shaded-18.0-rc1 > > > >> >> > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > >> >> > > [4] > > > >> >> > > > > > >> >> > > > >> > > https://repository.apache.org/content/repositories/orgapacheflink-1676/ > > > >> >> > > [5] > > > >> >> > > https://github.com/apache/flink-shaded/releases/tag/release-18.0-rc1 > > > >> >> > > [6] https://github.com/apache/flink-web/pull/701 > > > >> >> > > > > > >> >> > > > > >> >> > > > >> > > > > >> > > > > > > > > > > -- > > > Best regards, > > > Sergey > > > > > > > > -- > Best regards, > Sergey
