Hello, Thanks for driving, Leonard,
+1 (binding) - Verified signatures and checksums of source and binaries - Maven dist contains expected files - There are no binaries in the source archive - Release notes look good - Tag exists in Github - CI passes for v4.1 [1] (could not find a tag build, but this one is equivalent) - Sources build locally - Verified bundled dependencies are correctly reflected in NOTICE file Thanks, Danny [1] https://github.com/apache/flink-connector-pulsar/actions/runs/7164218129 On Wed, Dec 20, 2023 at 11:16 PM Sergey Nuyanzin <snuyan...@gmail.com> wrote: > +1 (non-binding) > > - Downloaded artifacts > - Maven staging artifacts look good > - Verified checksum && keys > - Verified LICENSE and NOTICE files > - Built from source > > On Wed, Dec 20, 2023 at 5:13 AM tison <wander4...@gmail.com> wrote: > > > Hi Leonard, > > > > You are a PMC member also. Perhaps you can check the candidate and > > vote on what you do :D > > > > Best, > > tison. > > > > Leonard Xu <xbjt...@gmail.com> 于2023年12月20日周三 11:35写道： > > > > > > Bubble up, I need more votes, especially from PMC members. > > > > > > Best, > > > Leonard > > > > > > > 2023年12月14日 下午11:03，Hang Ruan <ruanhang1...@gmail.com> 写道： > > > > > > > > +1 (non-binding) > > > > > > > > - Validated checksum hash > > > > - Verified signature > > > > - Verified that no binaries exist in the source archive > > > > - Build the source with jdk8 > > > > - Verified web PR > > > > - Make sure flink-connector-base have the provided scope > > > > > > > > Best, > > > > Hang > > > > > > > > tison <wander4...@gmail.com> 于2023年12月14日周四 11:51写道： > > > > > > > >> Thanks Leonard for driving this release! > > > >> > > > >> +1 (non-binding) > > > >> > > > >> * Download link valid > > > >> * Maven staging artifacts look good. > > > >> * Checksum and gpg matches > > > >> * LICENSE and NOTICE exist > > > >> * Can build from source. > > > >> > > > >> Best, > > > >> tison. > > > >> > > > >> Rui Fan <1996fan...@gmail.com> 于2023年12月14日周四 09:23写道： > > > >>> > > > >>> Thanks Leonard for driving this release! > > > >>> > > > >>> +1 (non-binding) > > > >>> > > > >>> - Validated checksum hash > > > >>> - Verified signature > > > >>> - Verified that no binaries exist in the source archive > > > >>> - Build the source with Maven and jdk8 > > > >>> - Verified licenses > > > >>> - Verified web PRs, left a minor comment > > > >>> > > > >>> Best, > > > >>> Rui > > > >>> > > > >>> On Wed, Dec 13, 2023 at 7:15 PM Leonard Xu <xbjt...@gmail.com> > > wrote: > > > >>>> > > > >>>> Hey all, > > > >>>> > > > >>>> Please review and vote on the release candidate #1 for the version > > > >> 4.1.0 of the Apache Flink Pulsar Connector as follows: > > > >>>> > > > >>>> [ ] +1, Approve the release > > > >>>> [ ] -1, Do not approve the release (please provide specific > > comments) > > > >>>> > > > >>>> The complete staging area is available for your review, which > > includes: > > > >>>> * JIRA release notes [1], > > > >>>> * The official Apache source release to be deployed to > > dist.apache.org > > > >> [2], which are signed with the key with fingerprint > > > >>>> 5B2F6608732389AEB67331F5B197E1F1108998AD [3], > > > >>>> * All artifacts to be deployed to the Maven Central Repository > [4], > > > >>>> * Source code tag v4.1.0-rc1 [5], > > > >>>> * Website pull request listing the new release [6]. > > > >>>> > > > >>>> The vote will be open for at least 72 hours. It is adopted by > > majority > > > >> approval, with at least 3 PMC affirmative votes. > > > >>>> > > > >>>> > > > >>>> Best, > > > >>>> Leonard > > > >>>> > > > >>>> [1] > > > >> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353431 > > > >>>> [2] > > > >> > > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-pulsar-4.1.0-rc1/ > > > >>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > >>>> [4] > > > >> > > https://repository.apache.org/content/repositories/orgapacheflink-1688/ > > > >>>> [5] > > https://github.com/apache/flink-connector-pulsar/tree/v4.1.0-rc1 > > > >>>> [6] https://github.com/apache/flink-web/pull/703 > > > >> > > > > > > > > -- > Best regards, > Sergey >
