Hi folks, Found another blocker issue for 1.18: https://github.com/apache/flink/pull/23950. Thanks Sergey for the heads-up.
Best regards, Jing On Mon, Dec 18, 2023 at 5:02 PM Jing Ge <j...@ververica.com> wrote: > Hi, > > I am waiting for the CI of > https://issues.apache.org/jira/browse/FLINK-33872 @Hong. It would be > great if anyone would like to review the PR. Thanks. > > 1.18.1-rc1 release will be canceled because of > https://issues.apache.org/jira/browse/FLINK-33704, I will start with rc2 > once FLINK-33872 has been merged into 1.18. > > Best regards, > Jing > > On Mon, Dec 18, 2023 at 11:52 AM Jing Ge <j...@ververica.com> wrote: > >> Hi folks, >> >> Thanks Martijn for driving the >> https://issues.apache.org/jira/browse/FLINK-33704, which will solve the >> issue of https://issues.apache.org/jira/browse/FLINK-33793. I will move >> forward with the 1.18.1 release today. >> >> Best regards, >> Jing >> >> On Thu, Dec 14, 2023 at 11:17 AM Jing Ge <j...@ververica.com> wrote: >> >>> Hi folks, >>> >>> What Martijn said makes sense. We should pay more attention to >>> https://issues.apache.org/jira/browse/FLINK-33793. I have also tried to >>> contribute and share my thoughts in the PR >>> https://github.com/apache/flink/pull/23489. >>> >>> For 1.18.1-rc1, I will wait until tomorrow. If there is no progress with >>> the PR, I will move forward with the release, unless we upgrade the ticket >>> to be a Blocker. Look forward to your feedback. >>> >>> Best regards, >>> Jing >>> >>> On Wed, Dec 13, 2023 at 9:57 AM Jing Ge <j...@ververica.com> wrote: >>> >>>> Hi Martijn, >>>> >>>> Thanks for the heads-up! I already started 1.18.1-rc1[1]. But please >>>> feel free to ping me. I will either redo rc1 or start rc2. Thanks! >>>> >>>> Best regards, >>>> Jing >>>> >>>> [1] https://dist.apache.org/repos/dist/dev/flink/flink-1.18.1-rc1/ >>>> >>>> On Tue, Dec 12, 2023 at 9:49 PM Martijn Visser < >>>> martijnvis...@apache.org> wrote: >>>> >>>>> Hi Jing, >>>>> >>>>> The only thing that was brought to my attention today was >>>>> https://issues.apache.org/jira/browse/FLINK-33793. I've marked it as a >>>>> Critical (I think we should have working checkpointing with GCS), but >>>>> could also be considered a Blocker. There is a PR open for it, but I >>>>> don't think it's the right fix so I'm testing >>>>> >>>>> https://github.com/apache/flink/commit/2ebe7f6e090690486c1954099a2b57283c578192 >>>>> at this moment. If you haven't started the 1.18.1 release yet, perhaps >>>>> we could include it (hopefully we can merge it tomorrow), else it >>>>> would have to wait for the next release. >>>>> >>>>> Thanks, >>>>> >>>>> Martijn >>>>> >>>>> On Tue, Dec 12, 2023 at 9:30 AM Jing Ge <j...@ververica.com.invalid> >>>>> wrote: >>>>> > >>>>> > Hi All, >>>>> > >>>>> > Thank you for your feedback! >>>>> > >>>>> > Since FLINK-33523[1] is done(thanks Martijn for driving it) and >>>>> there are >>>>> > no other concerns or objections. Currently I am not aware of any >>>>> unresolved >>>>> > blockers. There is one critical task[2] whose PR still has some >>>>> checkstyle >>>>> > issues. I will try to include it into 1.18.1 with best effort, since >>>>> it >>>>> > depends on how quickly the author can finish it and cp to 1.18. If >>>>> anyone >>>>> > considers FLINK-33588 as a must-have fix in 1.18.1, please let me >>>>> know, >>>>> > thanks! >>>>> > >>>>> > I will start working on the RC1 release today. >>>>> > >>>>> > @benchao: gotcha wrt FLINK-33313 >>>>> > >>>>> > Best regards, >>>>> > Jing >>>>> > >>>>> > [1] https://issues.apache.org/jira/browse/FLINK-33523 >>>>> > [2] https://issues.apache.org/jira/browse/FLINK-33588 >>>>> > >>>>> > On Tue, Dec 12, 2023 at 7:03 AM weijie guo < >>>>> guoweijieres...@gmail.com> >>>>> > wrote: >>>>> > >>>>> > > Thanks Jing for driving this bug-fix release. >>>>> > > >>>>> > > +1 from my side. >>>>> > > >>>>> > > Best regards, >>>>> > > >>>>> > > Weijie >>>>> > > >>>>> > > >>>>> > > Jark Wu <imj...@gmail.com> 于2023年12月12日周二 12:17写道: >>>>> > > >>>>> > > > Thanks Jing for driving 1.18.1. >>>>> > > > +1 for this. >>>>> > > > >>>>> > > > Best, >>>>> > > > Jark >>>>> > > > >>>>> > > > On Mon, 11 Dec 2023 at 16:59, Hong Liang <hlteo...@gmail.com> >>>>> wrote: >>>>> > > > >>>>> > > > > +1. Thanks Jing for driving this. >>>>> > > > > >>>>> > > > > Hong >>>>> > > > > >>>>> > > > > On Mon, Dec 11, 2023 at 2:27 AM Yun Tang <myas...@live.com> >>>>> wrote: >>>>> > > > > >>>>> > > > > > Thanks Jing for driving 1.18.1 release, +1 for this. >>>>> > > > > > >>>>> > > > > > >>>>> > > > > > Best >>>>> > > > > > Yun Tang >>>>> > > > > > ________________________________ >>>>> > > > > > From: Rui Fan <1996fan...@gmail.com> >>>>> > > > > > Sent: Saturday, December 9, 2023 21:46 >>>>> > > > > > To: dev@flink.apache.org <dev@flink.apache.org> >>>>> > > > > > Subject: Re: [DISCUSS] Release Flink 1.18.1 >>>>> > > > > > >>>>> > > > > > Thanks Jing for driving this release, +1 >>>>> > > > > > >>>>> > > > > > Best, >>>>> > > > > > Rui >>>>> > > > > > >>>>> > > > > > On Sat, Dec 9, 2023 at 7:33 AM Leonard Xu <xbjt...@gmail.com> >>>>> wrote: >>>>> > > > > > >>>>> > > > > > > Thanks Jing for driving this release, +1 >>>>> > > > > > > >>>>> > > > > > > Best, >>>>> > > > > > > Leonard >>>>> > > > > > > >>>>> > > > > > > > 2023年12月9日 上午1:23,Danny Cranmer <dannycran...@apache.org> >>>>> 写道: >>>>> > > > > > > > >>>>> > > > > > > > +1 >>>>> > > > > > > > >>>>> > > > > > > > Thanks for driving this >>>>> > > > > > > > >>>>> > > > > > > > On Fri, 8 Dec 2023, 12:05 Timo Walther, < >>>>> twal...@apache.org> >>>>> > > > wrote: >>>>> > > > > > > > >>>>> > > > > > > >> Thanks for taking care of this Jing. >>>>> > > > > > > >> >>>>> > > > > > > >> +1 to release 1.18.1 for this. >>>>> > > > > > > >> >>>>> > > > > > > >> Cheers, >>>>> > > > > > > >> Timo >>>>> > > > > > > >> >>>>> > > > > > > >> >>>>> > > > > > > >> On 08.12.23 10:00, Benchao Li wrote: >>>>> > > > > > > >>> I've merged FLINK-33313 to release-1.18 branch. >>>>> > > > > > > >>> >>>>> > > > > > > >>> Péter Váry <peter.vary.apa...@gmail.com> 于2023年12月8日周五 >>>>> > > 16:56写道: >>>>> > > > > > > >>>> >>>>> > > > > > > >>>> Hi Jing, >>>>> > > > > > > >>>> Thanks for taking care of this! >>>>> > > > > > > >>>> +1 (non-binding) >>>>> > > > > > > >>>> Peter >>>>> > > > > > > >>>> >>>>> > > > > > > >>>> Sergey Nuyanzin <snuyan...@gmail.com> ezt írta >>>>> (időpont: >>>>> > > 2023. >>>>> > > > > dec. >>>>> > > > > > > >> 8., P, >>>>> > > > > > > >>>> 9:36): >>>>> > > > > > > >>>> >>>>> > > > > > > >>>>> Thanks Jing driving it >>>>> > > > > > > >>>>> +1 >>>>> > > > > > > >>>>> >>>>> > > > > > > >>>>> also +1 to include FLINK-33313 mentioned by Benchao >>>>> Li >>>>> > > > > > > >>>>> >>>>> > > > > > > >>>>> On Fri, Dec 8, 2023 at 9:17 AM Benchao Li < >>>>> > > > libenc...@apache.org> >>>>> > > > > > > >> wrote: >>>>> > > > > > > >>>>> >>>>> > > > > > > >>>>>> Thanks Jing for driving 1.18.1 releasing. >>>>> > > > > > > >>>>>> >>>>> > > > > > > >>>>>> I would like to include FLINK-33313[1] in 1.18.1, >>>>> it's just >>>>> > > a >>>>> > > > > > > bugfix, >>>>> > > > > > > >>>>>> not a blocker, but it's already merged into master, >>>>> I plan >>>>> > > to >>>>> > > > > > merge >>>>> > > > > > > it >>>>> > > > > > > >>>>>> to 1.8/1.7 branches today after the CI passes. >>>>> > > > > > > >>>>>> >>>>> > > > > > > >>>>>> [1] >>>>> https://issues.apache.org/jira/browse/FLINK-33313 >>>>> > > > > > > >>>>>> >>>>> > > > > > > >>>>>> Jing Ge <j...@ververica.com.invalid> 于2023年12月8日周五 >>>>> 16:06写道: >>>>> > > > > > > >>>>>>> >>>>> > > > > > > >>>>>>> Hi all, >>>>> > > > > > > >>>>>>> >>>>> > > > > > > >>>>>>> I would like to discuss creating a new 1.18 patch >>>>> release >>>>> > > > > > (1.18.1). >>>>> > > > > > > >> The >>>>> > > > > > > >>>>>>> last 1.18 release is nearly two months old, and >>>>> since then, >>>>> > > > 37 >>>>> > > > > > > >> tickets >>>>> > > > > > > >>>>>> have >>>>> > > > > > > >>>>>>> been closed [1], of which 6 are blocker/critical >>>>> [2]. Some >>>>> > > > of >>>>> > > > > > them >>>>> > > > > > > >> are >>>>> > > > > > > >>>>>>> quite important, such as FLINK-33598 [3] >>>>> > > > > > > >>>>>>> >>>>> > > > > > > >>>>>>> Most urgent and important one is FLINK-33523 [4] >>>>> and >>>>> > > > according >>>>> > > > > to >>>>> > > > > > > the >>>>> > > > > > > >>>>>>> discussion thread[5] on the ML, 1.18.1 should/must >>>>> be >>>>> > > > released >>>>> > > > > > asap >>>>> > > > > > > >>>>> after >>>>> > > > > > > >>>>>>> the breaking change commit has been reverted. >>>>> > > > > > > >>>>>>> >>>>> > > > > > > >>>>>>> I am not aware of any other unresolved blockers >>>>> and there >>>>> > > are >>>>> > > > > no >>>>> > > > > > > >>>>>> in-progress >>>>> > > > > > > >>>>>>> tickets [6]. >>>>> > > > > > > >>>>>>> Please let me know if there are any issues you'd >>>>> like to be >>>>> > > > > > > included >>>>> > > > > > > >> in >>>>> > > > > > > >>>>>>> this release but still not merged. >>>>> > > > > > > >>>>>>> >>>>> > > > > > > >>>>>>> If the community agrees to create this new patch >>>>> release, I >>>>> > > > > could >>>>> > > > > > > >>>>>>> volunteer as the release manager. >>>>> > > > > > > >>>>>>> >>>>> > > > > > > >>>>>>> Best regards, >>>>> > > > > > > >>>>>>> Jing >>>>> > > > > > > >>>>>>> >>>>> > > > > > > >>>>>>> [1] >>>>> > > > > > > >>>>>>> >>>>> > > > > > > >>>>>> >>>>> > > > > > > >>>>> >>>>> > > > > > > >> >>>>> > > > > > > >>>>> > > > > > >>>>> > > > > >>>>> > > > >>>>> > > >>>>> https://issues.apache.org/jira/browse/FLINK-33567?jql=project%20%3D%20FLINK%20AND%20fixVersion%20%3D%201.18.1%20%20and%20resolution%20%20!%3D%20%20Unresolved%20order%20by%20priority%20DESC >>>>> > > > > > > >>>>>>> [2] >>>>> > > > > > > >>>>>>> >>>>> > > > > > > >>>>>> >>>>> > > > > > > >>>>> >>>>> > > > > > > >> >>>>> > > > > > > >>>>> > > > > > >>>>> > > > > >>>>> > > > >>>>> > > >>>>> https://issues.apache.org/jira/browse/FLINK-33693?jql=project%20%3D%20FLINK%20AND%20fixVersion%20%3D%201.18.1%20and%20resolution%20%20!%3D%20Unresolved%20%20and%20priority%20in%20(Blocker%2C%20Critical)%20ORDER%20by%20priority%20%20DESC >>>>> > > > > > > >>>>>>> [3] >>>>> https://issues.apache.org/jira/browse/FLINK-33598 >>>>> > > > > > > >>>>>>> [4] >>>>> https://issues.apache.org/jira/browse/FLINK-33523 >>>>> > > > > > > >>>>>>> [5] >>>>> > > > > > > >>>>> https://lists.apache.org/thread/m4c879y8mb7hbn2kkjh9h3d8g1jphh3j >>>>> > > > > > > >>>>>>> [6] >>>>> > > > > > > >>>>> https://issues.apache.org/jira/projects/FLINK/versions/12353640 >>>>> > > > > > > >>>>>>> Thanks, >>>>> > > > > > > >>>>>> >>>>> > > > > > > >>>>>> >>>>> > > > > > > >>>>>> >>>>> > > > > > > >>>>>> -- >>>>> > > > > > > >>>>>> >>>>> > > > > > > >>>>>> Best, >>>>> > > > > > > >>>>>> Benchao Li >>>>> > > > > > > >>>>>> >>>>> > > > > > > >>>>> >>>>> > > > > > > >>>>> >>>>> > > > > > > >>>>> -- >>>>> > > > > > > >>>>> Best regards, >>>>> > > > > > > >>>>> Sergey >>>>> > > > > > > >>>>> >>>>> > > > > > > >>> >>>>> > > > > > > >>> >>>>> > > > > > > >>> >>>>> > > > > > > >> >>>>> > > > > > > >> >>>>> > > > > > > >>>>> > > > > > > >>>>> > > > > > >>>>> > > > > >>>>> > > > >>>>> > > >>>>> >>>>