+1 (binding) - checked the flink-connector-base dependency scope has been changed to provided - built from source code succeeded - verified signatures - verified hashsums - checked the contents contains jar and pom files in apache repo - checked Github release tag - checked release notes - reviewed the web PR
Best, Leonard > 2023年11月26日 下午4:40，Jing Ge <j...@ververica.com.INVALID> 写道： > > +1 (non-binding) > > - verified signature and hash > - checked repo > - checked tag, BTW, the tag link at [5] should be > https://github.com/apache/flink-connector-kafka/releases/tag/v3.0.2-rc1 > - verified source archives do not contains any binaries > - build source maven 3.8.6 and jdk11 > - verified web PR > > Best regards, > Jing > > On Sat, Nov 25, 2023 at 6:44 AM Rui Fan <1996fan...@gmail.com> wrote: > >> +1 (non-binding) >> >> - Validated checksum hash >> - Verified signature >> - Verified that no binaries exist in the source archive >> - Build the source with Maven and jdk8 >> - Verified licenses >> - Verified web PRs >> >> Best, >> Rui >> >> On Sat, Nov 25, 2023 at 2:05 AM Tzu-Li (Gordon) Tai <tzuli...@apache.org> >> wrote: >> >>> +1 (binding) >>> >>> - Verified signature and hashes >>> - Verified mvn dependency:tree for a typical user job jar [1]. When using >>> Flink 1.18.0, flink-connector-base is no longer getting bundled, and all >>> Flink dependencies resolve as 1.18.0 / provided. >>> - Submitting user job jar to local Flink 1.18.0 cluster works and job >> runs >>> >>> note: If running in the IDE, the flink-connector-base dependency is >>> explicitly required when using KafkaSource. Otherwise, if submitting an >>> uber jar, the flink-connector-base dependency should not be bundled as >>> it'll be provided by the Flink distribution and will already be on the >>> classpath. >>> >>> [1] mvn dependency:tree output >>> ``` >>> [INFO] com.tzulitai:testing-kafka:jar:1.0-SNAPSHOT >>> [INFO] +- org.apache.flink:flink-streaming-java:jar:1.18.0:provided >>> [INFO] | +- org.apache.flink:flink-core:jar:1.18.0:provided >>> [INFO] | | +- org.apache.flink:flink-annotations:jar:1.18.0:provided >>> [INFO] | | +- org.apache.flink:flink-metrics-core:jar:1.18.0:provided >>> [INFO] | | +- org.apache.flink:flink-shaded-asm-9:jar:9.5-17.0:provided >>> [INFO] | | +- >>> org.apache.flink:flink-shaded-jackson:jar:2.14.2-17.0:provided >>> [INFO] | | +- org.apache.commons:commons-lang3:jar:3.12.0:provided >>> [INFO] | | +- org.apache.commons:commons-text:jar:1.10.0:provided >>> [INFO] | | +- com.esotericsoftware.kryo:kryo:jar:2.24.0:provided >>> [INFO] | | | +- com.esotericsoftware.minlog:minlog:jar:1.2:provided >>> [INFO] | | | \- org.objenesis:objenesis:jar:2.1:provided >>> [INFO] | | +- >> commons-collections:commons-collections:jar:3.2.2:provided >>> [INFO] | | \- org.apache.commons:commons-compress:jar:1.21:provided >>> [INFO] | +- org.apache.flink:flink-file-sink-common:jar:1.18.0:provided >>> [INFO] | +- org.apache.flink:flink-runtime:jar:1.18.0:provided >>> [INFO] | | +- org.apache.flink:flink-rpc-core:jar:1.18.0:provided >>> [INFO] | | +- >> org.apache.flink:flink-rpc-akka-loader:jar:1.18.0:provided >>> [INFO] | | +- >>> org.apache.flink:flink-queryable-state-client-java:jar:1.18.0:provided >>> [INFO] | | +- org.apache.flink:flink-hadoop-fs:jar:1.18.0:provided >>> [INFO] | | +- commons-io:commons-io:jar:2.11.0:provided >>> [INFO] | | +- >>> org.apache.flink:flink-shaded-netty:jar:4.1.91.Final-17.0:provided >>> [INFO] | | +- >>> org.apache.flink:flink-shaded-zookeeper-3:jar:3.7.1-17.0:provided >>> [INFO] | | +- org.javassist:javassist:jar:3.24.0-GA:provided >>> [INFO] | | +- org.xerial.snappy:snappy-java:jar:1.1.10.4:runtime >>> [INFO] | | \- org.lz4:lz4-java:jar:1.8.0:runtime >>> [INFO] | +- org.apache.flink:flink-java:jar:1.18.0:provided >>> [INFO] | | \- com.twitter:chill-java:jar:0.7.6:provided >>> [INFO] | +- >> org.apache.flink:flink-shaded-guava:jar:31.1-jre-17.0:provided >>> [INFO] | +- org.apache.commons:commons-math3:jar:3.6.1:provided >>> [INFO] | +- org.slf4j:slf4j-api:jar:1.7.36:runtime >>> [INFO] | \- com.google.code.findbugs:jsr305:jar:1.3.9:provided >>> [INFO] +- org.apache.flink:flink-clients:jar:1.18.0:provided >>> [INFO] | +- org.apache.flink:flink-optimizer:jar:1.18.0:provided >>> [INFO] | \- commons-cli:commons-cli:jar:1.5.0:provided >>> [INFO] +- org.apache.flink:flink-connector-kafka:jar:3.0.2-1.18:compile >>> [INFO] | +- org.apache.kafka:kafka-clients:jar:3.2.3:compile >>> [INFO] | | \- com.github.luben:zstd-jni:jar:1.5.2-1:runtime >>> [INFO] | +- com.fasterxml.jackson.core:jackson-core:jar:2.15.2:compile >>> [INFO] | +- >> com.fasterxml.jackson.core:jackson-databind:jar:2.15.2:compile >>> [INFO] | | \- >>> com.fasterxml.jackson.core:jackson-annotations:jar:2.15.2:compile >>> [INFO] | +- >>> com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.15.2:compile >>> [INFO] | \- >>> com.fasterxml.jackson.datatype:jackson-datatype-jdk8:jar:2.15.2:compile >>> [INFO] +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.17.1:runtime >>> [INFO] +- org.apache.logging.log4j:log4j-api:jar:2.17.1:runtime >>> [INFO] \- org.apache.logging.log4j:log4j-core:jar:2.17.1:runtime >>> ``` >>> >>> On Fri, Nov 24, 2023 at 9:19 AM Tzu-Li (Gordon) Tai <tzuli...@apache.org >>> >>> wrote: >>> >>>> Hi everyone, >>>> >>>> Please review and vote on release candidate #1 for version 3.0.2 of the >>>> Apache Flink Kafka Connector, as follows: >>>> [ ] +1, Approve the release >>>> [ ] -1, Do not approve the release (please provide specific comments) >>>> >>>> Compared to the previous hotfix release, this release only additionally >>>> contains a fix for FLINK-30400 ( >>>> https://issues.apache.org/jira/browse/FLINK-30400). >>>> >>>> The release candidate contains the source release as well as JAR >>> artifacts >>>> to be released to Maven, built against Flink 1.17.1 and 1.18.0. >>>> >>>> The complete staging area is available for your review, which includes: >>>> * JIRA release notes [1], >>>> * the official Apache source release to be deployed to dist.apache.org >>>> [2], which are signed with the key with fingerprint >>>> 1C1E2394D3194E1944613488F320986D35C33D6A [3], >>>> * all artifacts to be deployed to the Maven Central Repository [4], >>>> * source code tag v3.0.2-rc1 [5], >>>> * website pull request listing the new release [6]. >>>> >>>> The vote will be open for at least 72 hours. It is adopted by majority >>>> approval, with at least 3 PMC affirmative votes. >>>> >>>> Thanks, >>>> Gordon >>>> >>>> [1] >>>> >>> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353768 >>>> [2] >>>> >>> >> https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.0.2-rc1/ >>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >>>> [4] >>> https://repository.apache.org/content/repositories/orgapacheflink-1675 >>>> [5] https://github.com/apache/flink-connector-kafka/commits/v3.0.2-rc1 >>>> [6] https://github.com/apache/flink-web/pull/700 >>>> >>> >>
