+1 (non-binding) - Downloaded artifacts - Built Flink from sources - Verified checksums & signatures - Verified pom/NOTICE files - reviewed the web PR
On Thu, Nov 23, 2023 at 12:49 PM Leonard Xu <xbjt...@gmail.com> wrote: > +1 (binding) > > - verified signatures > - verified hashsums > - checked all dependency artifacts are 1.17.2 > - started SQL Client, used MySQL CDC connector to read changelog from > database , the result is expected > - reviewed the web PR > > Best, > Leonard > > > 2023年11月22日 下午11:13,Danny Cranmer <dannycran...@apache.org> 写道: > > > > Thanks for driving this release. > > > > +1 (binding) > > > > - Verified signatures and checksums > > - Verified there are no binaries in the source archive > > - Run simple Kinesis job on binary dist, verified consumer, map and > print. > > The Flink dashboard looks good. > > - Built from source successfully > > - Contents of maven repo looks good > > - Tag is present in git > > - Left comments on the web PR > > - Not a blocker, the copyright header in NOTICE has outdated year, 2022 > > should be 2023 "Copyright 2014-2022 The Apache Software Foundation" > > - Verified a handful of NOTICE files and they look correct > > > > Thanks, > > Danny > > > > On Tue, Nov 21, 2023 at 12:48 PM Matthias Pohl > > <matthias.p...@aiven.io.invalid> wrote: > > > >> +1 (binding) > >> > >> * Downloaded artifacts > >> * Built Flink from sources > >> * Verified SHA512 checksums & GPG signatures > >> * Compared checkout with provided sources > >> * Verified pom file versions > >> * Went over NOTICE/pom file changes without finding anything suspicious > >> * Deployed standalone session cluster and ran WordCount example in batch > >> and streaming: Nothing suspicious in log files found > >> * Verified Java version of uploaded binaries > >> > >> Thanks Yun Tang for taking care of it. > >> > >> On Thu, Nov 16, 2023 at 7:02 AM Rui Fan <1996fan...@gmail.com> wrote: > >> > >>> +1 (non-binding) > >>> > >>> - Verified signatures > >>> - Reviewed the flink-web PR, left a couple of comments > >>> - The source archives do not contain any binaries > >>> - Build the source with Maven 3 and java8 (Checked the license as well) > >>> - bin/start-cluster.sh with java8, it works fine and no any unexpected > >> LOG > >>> - Ran demo, it's fine: bin/flink run > >>> examples/streaming/StateMachineExample.jar > >>> > >>> Best, > >>> Rui > >>> > >>> On Mon, Nov 13, 2023 at 4:04 PM Yun Tang <myas...@live.com> wrote: > >>> > >>>> Hi everyone, > >>>> > >>>> Please review and vote on the release candidate #1 for the version > >>> 1.17.2, > >>>> > >>>> as follows: > >>>> > >>>> [ ] +1, Approve the release > >>>> > >>>> [ ] -1, Do not approve the release (please provide specific comments) > >>>> > >>>> > >>>> The complete staging area is available for your review, which > includes: > >>>> * JIRA release notes [1], > >>>> > >>>> * the official Apache source release and binary convenience releases > to > >>> be > >>>> deployed to dist.apache.org [2], which are signed with the key with > >>>> fingerprint 2E0E1AB5D39D55E608071FB9F795C02A4D2482B3 [3], > >>>> > >>>> * all artifacts to be deployed to the Maven Central Repository [4], > >>>> > >>>> * source code tag "release-1.17.2-rc1" [5], > >>>> > >>>> * website pull request listing the new release and adding announcement > >>>> blog post [6]. > >>>> > >>>> > >>>> The vote will be open for at least 72 hours. It is adopted by majority > >>>> approval, with at least 3 PMC affirmative votes. > >>>> > >>>> > >>>> [1] > >>>> > >>> > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353260 > >>>> > >>>> [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.17.2-rc1/ > >>>> > >>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > >>>> > >>>> [4] > >>>> > >> https://repository.apache.org/content/repositories/orgapacheflink-1669/ > >>>> > >>>> [5] https://github.com/apache/flink/releases/tag/release-1.17.2-rc1 > >>>> > >>>> [6] https://github.com/apache/flink-web/pull/696 > >>>> > >>>> Thanks, > >>>> Release Manager > >>>> > >>> > >> > > -- Best regards, Sergey