Hi devs, After discussing with @Qingsheng, I fixed a minor issue of the lineage lifecycle in `StreamExecutionEnvironment`. I have added the comment to explain that the lineage information in `StreamExecutionEnvironment` will be consistent with that of transformations. When users clear the existing transformations, the added lineage information will also be deleted.
Please help to review it again, and If there are no more concerns about FLIP -314[1], I would like to start voting later, thanks. cc @Leonard Best, Shammon FY On Mon, Jul 17, 2023 at 3:43 PM Shammon FY <zjur...@gmail.com> wrote: > Hi devs, > > Thanks for all the valuable feedback. If there are no more concerns about > FLIP-314[1], I would like to start voting later, thanks. > > > [1] > https://cwiki.apache.org/confluence/display/FLINK/FLIP-314%3A+Support+Customized+Job+Lineage+Listener > > Best, > Shammon FY > > > On Wed, Jul 12, 2023 at 11:18 AM Shammon FY <zjur...@gmail.com> wrote: > >> Thanks for the valuable feedback, Leonard. >> >> I have discussed with Leonard off-line. We have reached some conclusions >> about these issues and I have updated the FLIP as follows: >> >> 1. Simplify the `LineageEdge` interface by creating an edge from one >> source vertex to sink vertex. >> 2. Remove the `TableColumnSourceLineageVertex` interface and update >> `TableColumnLineageEdge` to create an edge from columns in one source to >> each sink column. >> 3. Rename `SupportsLineageVertex` to `LineageVertexProvider` >> 4. Add method `addLineageEdges(LineageEdge ... edges)` in >> `StreamExecutionEnviroment` for datastream job and remove previous methods >> in `DataStreamSource` and `DataStreamSink`. >> >> Looking forward to your feedback, thanks. >> >> Best, >> Shammon FY >> >
