+1 for this FLIP Maybe a FLIP is an overkill for this enhancement.
Best, Yang Venkatakrishnan Sowrirajan <vsowr...@asu.edu> 于2023年8月23日周三 01:44写道： > Thanks for the FLIP, Archit. > > This is definitely quite a useful addition to the *yarn.provided.lib.dirs* > . +1. > > IMO, except for the fact that *yarn.provided.lib.dirs* (platform specific > jars can be cached) takes only directories whereas *yarn.ship-files* (user > files) takes both files and dirs, the overall logic in terms of > constructing the classpath in both the cases should be roughly the same. > > Referencing the PR (https://github.com/apache/flink/pull/23164) with the > initial implementation you created as well here. > > Regards > Venkata krishnan > > > On Tue, Aug 22, 2023 at 10:09 AM Archit Goyal <argo...@linkedin.com.invalid > > > wrote: > > > Hi all, > > > > Gentle ping if I can get a review on the FLIP. > > > > Thanks, > > Archit Goyal > > > > From: Archit Goyal <argo...@linkedin.com> > > Date: Thursday, August 17, 2023 at 5:51 PM > > To: dev@flink.apache.org <dev@flink.apache.org> > > Subject: [Discuss] FLIP-355: Add parent dir of files to classpath using > > yarn.provided.lib.dirs > > Hi All, > > > > I am opening this thread to discuss the proposal to add parent > directories > > of files to classpath when using yarn.provided.lib.dirs. This is > documented > > in FLIP-355 < > > > https://urldefense.com/v3/__https://cwiki.apache.org/confluence/display/FLINK/FLIP*355*3A*Add*parent*dir*of*files*to*classpath*using*yarn.provided.lib.dirs__;KyUrKysrKysrKys!!IKRxdwAv5BmarQ!fFlyBKWuWwYcWfOcpLflTTi36tyHPiENIUry9J0ygaZY0VURnIs0glu5yafV0w0tfSsnOb9ZxDD9Cjw2TApTekVU$ > > >. > > > > This FLIP mentions about enhancing YARN's classpath configuration to > > include parent directories of files in yarn.provided.lib.dirs. > > > > Please feel free to reply to this email thread and share your opinions. > > > > Thanks, > > Archit Goyal > > >
