Thanks for letting us know, Alexander and Leonard! I checked these PRs and the changes are trivial. +1 for merging them.
Best, Qingsheng On Tue, Aug 1, 2023 at 12:14 AM Leonard Xu <xbjt...@gmail.com> wrote: > Thank all Release Managers for driving the 1.18 release work! > > > - Deprecation works for 2.0 > > > > As discussed in another thread [3], we will not give extra extensions to > > deprecation works considering the overhead and potential side effects to > > the timeline of 1.18. We can accept tiny changes that only add > annotations > > and JavaDocs, but please let us know before you are going to do that. > > Alexander and I ready to deprecate SourceFunction APIs as above discussion > thread[1][2], now we apply the permission to merge following three PRs : > > The first two PRs [3][4] only contains @Deprecated annotations and > JavaDocs, the PR[5] contains @Deprecated annotations, JavaDocs, and > necessary tiny changes for example code as some examples with strict > deprecation compiler checks to SourceFunction API, it should be okay as it > only changed example code, you can check the tiny change in this commit[5]. > > Best, > Alexander and Leonard > > [1]https://lists.apache.org/thread/yyw52k45x2sp1jszldtdx7hc98n72w7k > [2]https://lists.apache.org/thread/kv9rj3w2rmkb8jtss5bqffhw57or7v8v > [3]https://github.com/apache/flink/pull/23106 > [4]https://github.com/apache/flink/pull/23079 > [5]https://github.com/apache/flink/pull/23105 > [6] > https://github.com/apache/flink/pull/23079/commits/f5ea3c073d36f21fb4fe47e83c717ac080995509 > >
