+1 Best, Ron
Jing Ge <j...@ververica.com.invalid> 于2023年7月26日周三 23:39写道： > +1(binding). > > Theoretically, I agree with Matthias. But in the practices, afaic, those > touched classes are low level APIs. We'd better have enough time to > evaluate them with care. More time might be needed than we could have > before the 1.18 release. A follow-up ticket might solve the concern. WDYT? > > Best regards, > Jing > > On Wed, Jul 26, 2023 at 4:25 PM Matthias Pohl > <matthias.p...@aiven.io.invalid> wrote: > > > -0 (binding) > > > > I'm not going to block this effort because it's still possible to cover > > other occurrences in a subsequent FLIP if it's considered useful (I'm not > > in the position to judge how important the IOReadableWritable interface > is > > in the context of removing the DataSet API). > > > > The recent discussion around what is allowed to be added to 1.18 after > the > > feature freeze [1] prevents us from moving forward with FLIP-347 in 1.18, > > anyway. Therefore, we could use the time to extend the FLIP to become a > > larger effort around making IOReadableWritable implementations immutable > as > > suggested in FLINK-4758 [2]. > > > > I mentioned this in the FLIP's discussion thread as well. > > > > [1] https://lists.apache.org/thread/7l1c9ybqgyc1mx7t7tk4wkc1cm8481o9 > > [2] https://issues.apache.org/jira/browse/FLINK-4758 > > > > On Wed, Jul 26, 2023 at 10:21 AM weijie guo <guoweijieres...@gmail.com> > > wrote: > > > > > +1 (binding) > > > > > > Best regards, > > > > > > Weijie > > > > > > > > > Yuxin Tan <tanyuxinw...@gmail.com> 于2023年7月26日周三 16:11写道： > > > > > > > +1 (non-binding) > > > > > > > > Best, > > > > Yuxin > > > > > > > > > > > > Xintong Song <tonysong...@gmail.com> 于2023年7月26日周三 16:09写道： > > > > > > > > > +1 (binding) > > > > > > > > > > Best, > > > > > > > > > > Xintong > > > > > > > > > > > > > > > > > > > > On Wed, Jul 26, 2023 at 2:29 PM Wencong Liu <liuwencle...@163.com> > > > > wrote: > > > > > > > > > > > Hi dev, > > > > > > > > > > > > > > > > > > I'd like to start a vote on FLIP-347. > > > > > > > > > > > > > > > > > > Discussion thread: > > > > > > https://lists.apache.org/thread/3gcxhnqpsvb85golnlxf9tv5p43xkjgj > > > > > > FLIP: > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-347%3A+Remove+IOReadableWritable+serialization+in+Path > > > > > > > > > > > > > > > > > > Best regards, > > > > > > Wencong Liu > > > > > > > > > > > > > > >
