Thanks all. This vote is now closed, I'll announce the results in a separate thread.
On Tue, May 9, 2023 at 11:15 AM Danny Cranmer <dannycran...@apache.org> wrote: > +1 (binding) > > - Release notes look good > - Verified signature and hashes of source/maven binary > - Verified there are no binaries in the source archive > - Tag is present in Github > - Reviewed web PR > - Built from source, tests pass > > - Year in NOTICE file needs updating, not a blocker > > Thanks, > Danny > > On Fri, May 5, 2023 at 8:15 AM Khanh Vu <vtkhan...@gmail.com> wrote: > > > +1 (non-binding) > > > > - Verified sha512 checksum matches file archive. > > - Verified file archive is signed and signature is authorized. > > - Verified no binaries exist in the source archive. > > - Verified source archive is consistent with Github source code with > > tag v3.0.1-rc1, at commit 73e56edb2aa4513f6a73dc071545fb2508fd2d44 > > - Source built successfully with maven. > > - Executed end to end tests successfully for flink versions: 1.15.4, > > 1.16.1, 1.17.0 > > > > Best regards, > > Khanh Vu > > > > > > On Thu, May 4, 2023 at 5:01 AM Leonard Xu <xbjt...@gmail.com> wrote: > > > > > +1 (binding) > > > > > > - built from source code succeeded > > > - verified signatures > > > - verified hashsums > > > - checked Github release tag > > > - checked release notes > > > - reviewed the web PR > > > > > > Best, > > > Leonard > > > > > > > 2023年4月20日 上午3:17，Martijn Visser <martijnvis...@apache.org> 写道： > > > > > > > > +1 (binding) > > > > > > > > - Validated hashes > > > > - Verified signature > > > > - Verified that no binaries exist in the source archive > > > > - Build the source with Maven > > > > - Verified licenses > > > > - Verified web PRs > > > > > > > > On Fri, Apr 14, 2023 at 6:15 PM Ryan Skraba > > <ryan.skr...@aiven.io.invalid > > > > > > > > wrote: > > > > > > > >> Hello! +1 (non-binding) > > > >> > > > >> I've validated the source for the RC1: > > > >> flink-connector-gcp-pubsub-3.0.1-src.tgz > > > >> * The sha512 checksum is OK. > > > >> * The source file is signed correctly. > > > >> * The signature A5F3BCE4CBE993573EC5966A65321B8382B219AF is found in > > the > > > >> KEYS file, and on https://keys.openpgp.org > > > >> * The source file is consistent with the Github tag v3.0.1-rc1, > which > > > >> corresponds to commit 73e56edb2aa4513f6a73dc071545fb2508fd2d44 > > > >> - The files explicitly excluded by create_pristine_sources (such > as > > > >> .gitignore and the submodule tools/releasing/shared) are not > present. > > > >> * Has a LICENSE file and a NOTICE filel > > > >> * Does not contain any compiled binaries. > > > >> > > > >> * The sources can be compiled and unit tests pass with flink.version > > > 1.17.0 > > > >> and flink.version 1.16.1 > > > >> > > > >> * Nexus has three staged artifact ids for 3.0.1-1.16 and 3.0.1-1.17 > > > >> - flink-connector-gcp-pubsub (.jar, -javadoc.jar, -sources.jar and > > .pom) > > > >> - flink-connector-gcp-pubsub-e2e-tests (.jar, -sources.jar and .pom) > > > >> - flink-connector-gcp-pubsub-parent (only .pom) > > > >> * All 16 files have been signed with the same key as above, and have > > > >> correct sha1 and md5 checksums. > > > >> > > > >> Simple smoke testing on an emulated Pub/Sub service works for both > > flink > > > >> versions. > > > >> > > > >> One really minor point: it looks like the > > > >> org.apache.flink:flink-connector-gcp-pubsub-parent:3.0.1-1.17:pom > has > > > the > > > >> flink-version set to 1.16.0. This is a bit confusing, but all the > > flink > > > >> transitive dependencies are in the provided scope, so there's no > > > >> consequence. I guess we could argue that it is the "source" > > > compatibility > > > >> level for both versions! > > > >> > > > >> All my best and thanks for the release. > > > >> > > > >> Ryan > > > >> > > > >> > > > >> > > > >> > > > >> > > > >> > > > >> On Thu, Apr 13, 2023 at 4:07 PM Martijn Visser < > > > martijnvis...@apache.org> > > > >> wrote: > > > >> > > > >>> Hi everyone, > > > >>> Please review and vote on the release candidate #1 for the version > > > 3.0.1, > > > >>> as follows: > > > >>> [ ] +1, Approve the release > > > >>> [ ] -1, Do not approve the release (please provide specific > comments) > > > >>> > > > >>> This version is compatible with Flink 1.16.x and Flink 1.17.x. > > > >>> > > > >>> The complete staging area is available for your review, which > > includes: > > > >>> * JIRA release notes [1], > > > >>> * the official Apache source release to be deployed to > > dist.apache.org > > > >>> [2], > > > >>> which are signed with the key with fingerprint > > > >>> A5F3BCE4CBE993573EC5966A65321B8382B219AF [3], > > > >>> * all artifacts to be deployed to the Maven Central Repository [4], > > > >>> * source code tag v3.0.1-rc1 [5], > > > >>> * website pull request listing the new release [6]. > > > >>> > > > >>> The vote will be open for at least 72 hours. It is adopted by > > majority > > > >>> approval, with at least 3 PMC affirmative votes. > > > >>> > > > >>> Thanks, > > > >>> Release Manager > > > >>> > > > >>> [1] > > > >>> > > > >>> > > > >> > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352770 > > > >>> [2] > > > >>> > > > >>> > > > >> > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-gcp-pubsub-3.0.1-rc1 > > > >>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > >>> [4] > > > >>> > > > > https://repository.apache.org/content/repositories/orgapacheflink-1613/ > > > >>> [5] > > > >>> > > > >>> > > > >> > > > > > > https://github.com/apache/flink-connector-gcp-pubsub/releases/tag/v3.0.1-rc1 > > > >>> [6] https://github.com/apache/flink-web/pull/637 > > > >>> > > > >> > > > > > > > > >
