+1 (binding) - built from source code succeeded - verified signatures - verified hashsums - checked Github release tag - reviewed the web PR
Best, Leonard > 2023年4月20日 上午3:29，Martijn Visser <martijnvis...@apache.org> 写道： > > +1 (binding) > > - Validated hashes > - Verified signature > - Verified that no binaries exist in the source archive > - Build the source with Maven > - Verified licenses > - Verified web PRs > > On Mon, Apr 17, 2023 at 7:00 PM Ryan Skraba <ryan.skr...@aiven.io.invalid> > wrote: > >> Hello! +1 (non-binding) >> >> I've validated the source for the RC1: >> flink-connector-rabbitmq-3.0.1-src.tgz >> * The sha512 checksum is OK. >> * The source file is signed correctly. >> * The signature A5F3BCE4CBE993573EC5966A65321B8382B219AF is found in the >> KEYS file, and on https://keys.openpgp.org >> * The source file is consistent with the Github tag v3.0.1-rc1, which >> corresponds to commit 9827e71662c8f155cda5efe5ebbac804fd0fd8e2 >> - The files explicitly excluded by create_pristine_sources (such as >> .gitignore and the submodule tools/releasing/shared) are not present. >> * Has a LICENSE file and a NOTICE file. The sql-connector has a >> NOTICE file for bundled artifacts. >> * Does not contain any compiled binaries. >> >> * The sources can be compiled and tests pass with flink.version 1.17.0 and >> flink.version 1.16.1 >> >> * Nexus has three staged artifact ids for 3.0.1-1.16 and 3.0.1-1.17 >> - flink-connector-rabbitmq-parent (only .pom) >> - flink-connector-rabbitmq (.jar, -sources.jar, -javadoc.jar and .pom) >> - flink-sql-connector-rabbitmq (.jar, -sources.jar and .pom) >> * All 16 files have been signed with the same key as above, and have >> correct sha1 and md5 checksums. >> >> I didn't run any additional smoke tests other than the integration test >> cases. >> >> A couple minor points, but nothing that would block this release. >> >> - like flink-connector-gcp-pubsub-parent, the >> flink-connector-rabbitmq-parent:3.0.1-1.17 pom artifact has the >> flink.version set to 1.16.0, which might be confusing. >> - the NOTICE file for sql-connector has the wrong year. >> >> All my best and thanks for the release. >> >> Ryan >> >> >> On Thu, Apr 13, 2023 at 4:45 PM Martijn Visser <martijnvis...@apache.org> >> wrote: >> >>> Hi everyone, >>> Please review and vote on the release candidate #1 for the version 3.0.1, >>> as follows: >>> [ ] +1, Approve the release >>> [ ] -1, Do not approve the release (please provide specific comments) >>> >>> This version is compatible with Flink 1.16.x and Flink 1.17.x >>> >>> The complete staging area is available for your review, which includes: >>> * JIRA release notes [1], >>> * the official Apache source release to be deployed to dist.apache.org >>> [2], >>> which are signed with the key with fingerprint >>> A5F3BCE4CBE993573EC5966A65321B8382B219AF [3], >>> * all artifacts to be deployed to the Maven Central Repository [4], >>> * source code tag v3.0.1-rc1 [5], >>> * website pull request listing the new release [6]. >>> >>> The vote will be open for at least 72 hours. It is adopted by majority >>> approval, with at least 3 PMC affirmative votes. >>> >>> Thanks, >>> Release Manager >>> >>> [1] >>> >>> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352699 >>> [2] >>> >>> >> https://dist.apache.org/repos/dist/dev/flink/flink-connector-rabbitmq-3.0.1-rc1 >>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >>> [4] >>> https://repository.apache.org/content/repositories/orgapacheflink-1615/ >>> [5] >>> >> https://github.com/apache/flink-connector-rabbitmq/releases/tag/v3.0.1-rc1 >>> [6] https://github.com/apache/flink-web/pull/639 >>> >>
