+1 (non-binding) - Verified sha512 checksum matches file archive. - Verified file archive is signed and signature is authorized. - Verified no binaries exist in the source archive. - Verified source archive is consistent with Github source code with tag v1.0.1-rc1, at commit c52dbf4fc9c473592479a6c4fc6b2b5227699737 - Source built successfully with maven. - Verified files contain license header by running apache-rat:check (except 2 files: README.md & .editorconfig) - Executed end to end tests successfully for flink versions: 1.16.1, 1.17.0 (failed for 1.15.4, I supposed the connector only works with Flink 1.16.x onwards)
Suggestion: it would be nice if in README we're explicitly stating that since which Flink version the connector works with. Best regards, *Khanh Vu* On Wed, Apr 19, 2023 at 8:12 PM Martijn Visser <martijnvis...@apache.org> wrote: > +1 (binding) > > - Validated hashes > - Verified signature > - Verified that no binaries exist in the source archive > - Build the source with Maven > - Verified licenses > - Verified web PRs > > Note: the copyright year in the NOTICE files have been updated to 2023 > > On Wed, Apr 19, 2023 at 9:43 AM Danny Cranmer <dannycran...@apache.org> > wrote: > > > Thanks for driving, Martijn. > > > > +1 (binding) > > > > - Release notes look good > > - Verified source archive signature/checksums > > - Verified binary signature/checksums > > - Verified no binaries in the source archive > > - Source tag exists on GitHub > > - Reviewed web PR > > - Verified NOTICE files > > > > Observations > > - NOTICE files need the year updating to 2023 > > > > Thanks, > > Danny > > > > > > On Tue, Apr 18, 2023 at 5:19 PM Ryan Skraba <ryan.skr...@aiven.io.invalid > > > > wrote: > > > > > Hello! +1 (non-binding) > > > > > > I've validated the source for the RC1: > > > flink-connector-opensearch-1.0.1-src.tgz > > > * The sha512 checksum is OK. > > > * The source file is signed correctly. > > > * The signature A5F3BCE4CBE993573EC5966A65321B8382B219AF is found in > the > > > KEYS file, and on https://keys.openpgp.org > > > * The source file is consistent with the Github tag v1.0.1-rc1, which > > > corresponds to commit c52dbf4fc9c473592479a6c4fc6b2b5227699737 > > > - The files explicitly excluded by create_pristine_sources (such as > > > .gitignore and the submodule tools/releasing/shared) are not present. > > > * Has a LICENSE file and a NOTICE file. The sql-connector has a > > > NOTICE file for bundled artifacts. > > > * Does not contain any compiled binaries. > > > > > > * The sources can be compiled and tests pass with flink.version 1.17.0 > > and > > > flink.version 1.16.1 > > > > > > * Nexus has three staged artifact ids for 1.0.1-1.16 and 1.0.1-1.17 > > > - flink-connector-opensearch-parent (only .pom) > > > - flink-connector-opensearch (.jar, -sources.jar, -javadoc.jar, > > -tests.jar > > > and .pom) > > > - flink-sql-connector-opensearch (.jar, -sources.jar and .pom) > > > * All 18 files have been signed with the same key as above, and have > > > correct sha1 and md5 checksums. > > > > > > I didn't run any additional smoke tests other than the integration test > > > cases. > > > > > > A couple minor points, but nothing that would block this release. > > > > > > - like the other connectors I've checked, flink.version in the parent > pom > > > is set to 1.16.0 even for 1.17 artifacts, which might be confusing. > > > - the NOTICE files have the wrong year. > > > - unlike other connectors, flink-connector-opensearch publishes the > > > -tests.jar classifier to nexus. Is this desired? > > > - The sql-connector PackagingITCase test fails when using > > > `-Prelease,docs-and-source`, but otherwise works as intended. > > > > > > All my best and thanks for the release. > > > > > > Ryan > > > > > > On Thu, Apr 13, 2023 at 3:39 PM Andrey Redko <drr...@gmail.com> wrote: > > > > > > > +1 (non-binding), thanks Martijn! > > > > > > > > Best Regards, > > > > Andriy Redko > > > > > > > > On Thu, Apr 13, 2023, 8:54 AM Martijn Visser < > martijnvis...@apache.org > > > > > > > wrote: > > > > > > > > > Hi everyone, > > > > > Please review and vote on the release candidate #1 for the version > > > 1.0.1, > > > > > as follows: > > > > > [ ] +1, Approve the release > > > > > [ ] -1, Do not approve the release (please provide specific > comments) > > > > > > > > > > > > > > > The complete staging area is available for your review, which > > includes: > > > > > * JIRA release notes [1], > > > > > * the official Apache source release to be deployed to > > dist.apache.org > > > > > [2], > > > > > which are signed with the key with fingerprint > > > > > A5F3BCE4CBE993573EC5966A65321B8382B219AF [3], > > > > > * all artifacts to be deployed to the Maven Central Repository [4], > > > > > * source code tag v1.0.1-rc1 [5], > > > > > * website pull request listing the new release [6]. > > > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > > majority > > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > Thanks, > > > > > Release Manager > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352686 > > > > > [2] > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-opensearch-1.0.1-rc1 > > > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > [4] > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1612/ > > > > > [5] https://github.com/apache/flink-connector- > > > > > <connector>/releases/tag/v1.0.1-rc1 > > > > > [6] https://github.com/apache/flink-web/pull/636 > > > > > > > > > > > > > > >
