+1 (binding) - Validated hashes - Verified signature - Verified that no binaries exist in the source archive - Build the source with Maven - Verified licenses - Verified web PRs
On Wed, Apr 19, 2023 at 9:35 AM Martijn Visser <martijnvis...@apache.org> wrote: > Hi all, > > There was already a blocker ticken op for this, that's > https://issues.apache.org/jira/browse/FLINK-31770. There's also an open > PR that should resolve it, but is waiting on a reviewer. See > https://github.com/apache/flink-connector-jdbc/pull/22 > > I've already done the administration, so this is just fyi :) > > Best regards, > > Martijn > > On Wed, Apr 19, 2023 at 9:17 AM Danny Cranmer <dannycran...@apache.org> > wrote: > >> Thank Benchao for the hotfix. I noticed the CI is also failing/flaky for >> the main branch, I have raised a follow-up [1]. >> >> Danny, >> >> [1] https://issues.apache.org/jira/browse/FLINK-31847 >> >> On Sun, Apr 16, 2023 at 10:57 AM Benchao Li <libenc...@apache.org> wrote: >> >> > And I've filed a hotfix PR[1] to fix the copyright issue. >> > >> > [1] https://github.com/apache/flink-connector-jdbc/pull/41 >> > >> > Benchao Li <libenc...@apache.org> 于2023年4月16日周日 17:51写道： >> > >> > > * Verified hashes, signatures (OK) >> > > * Download, build and test source code (OK) >> > > * Checked files in Nexus staging (OK) >> > > * Start a Flink local cluster (1.17.0), run sql-client with jdbc >> > > connector jar with Mysql 8.0.28 (OK) >> > > * Go through the release note (OK) >> > > >> > > One thing I spotted is that when I checked the NOTICE file, I found >> that >> > > we have not updated the copyright year to 2023, I'm not sure whether >> we >> > > should take this as a blocker issue. If not, my vote is +1. >> > > >> > > And I left my comments in the PR for website updating. >> > > >> > > Teoh, Hong <lian...@amazon.co.uk.invalid> 于2023年4月14日周五 15:54写道： >> > > >> > >> Thanks Danny >> > >> >> > >> +1 (non-binding) >> > >> >> > >> * Hashes and Signatures look good >> > >> * All required files on dist.apache.org >> > >> * Tag is present in Github >> > >> * Verified source archive does not contain any binary files >> > >> * Source archive builds using maven >> > >> >> > >> >> > >> Cheers, >> > >> Hong >> > >> >> > >> >> > >> > On 14 Apr 2023, at 05:21, Elphas Toringepi <elphast...@gmail.com> >> > >> wrote: >> > >> > >> > >> > CAUTION: This email originated from outside of the organization. Do >> > not >> > >> click links or open attachments unless you can confirm the sender and >> > know >> > >> the content is safe. >> > >> > >> > >> > >> > >> > >> > >> > +1 (non-binding) >> > >> > >> > >> > * JIRA release notes look good >> > >> > * Verified signature and checksum for Apache source >> > >> > * Checked source code tag and confirmed Github and Apache source >> > >> releases >> > >> > are identical >> > >> > * Reviewed website pull request and left comment >> > >> > >> > >> > Kind regards, >> > >> > Elphas >> > >> > >> > >> > >> > >> > On Thu, Apr 13, 2023 at 3:42 PM Danny Cranmer < >> > dannycran...@apache.org> >> > >> > wrote: >> > >> > >> > >> >> Hi everyone, >> > >> >> Please review and vote on the release candidate #1 for the version >> > >> v3.1.0, >> > >> >> as follows: >> > >> >> [ ] +1, Approve the release >> > >> >> [ ] -1, Do not approve the release (please provide specific >> comments) >> > >> >> >> > >> >> This version supports both Flink 1.16.x and Flink 1.17.x >> > >> >> >> > >> >> The complete staging area is available for your review, which >> > includes: >> > >> >> * JIRA release notes [1], >> > >> >> * the official Apache source release to be deployed to >> > dist.apache.org >> > >> >> [2], >> > >> >> which are signed with the key with fingerprint >> > >> >> 0F79F2AFB2351BC29678544591F9C1EC125FD8DB [3], >> > >> >> * all artifacts to be deployed to the Maven Central Repository >> [4], >> > >> >> * source code tag v3.1.0-rc1 [5], >> > >> >> * website pull request listing the new release [6]. >> > >> >> >> > >> >> The vote will be open for at least 72 hours. It is adopted by >> > majority >> > >> >> approval, with at least 3 PMC affirmative votes. >> > >> >> >> > >> >> Thanks, >> > >> >> Danny >> > >> >> >> > >> >> [1] >> > >> >> >> > >> >> >> > >> >> > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352678 >> > >> >> [2] >> > >> >> >> > >> >> > >> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.0-rc1 >> > >> >> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >> > >> >> [4] >> > >> >> >> > >> >> https://repository.apache.org/content/repositories/orgapacheflink-1614/ >> > >> >> [5] >> > >> >> https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.0-rc1 >> > >> >> [6] https://github.com/apache/flink-web/pull/638 >> > >> >> >> > >> >> > >> >> > > >> > > -- >> > > >> > > Best, >> > > Benchao Li >> > > >> > >> > >> > -- >> > >> > Best, >> > Benchao Li >> > >> >
