This is a good proposal for me, it will make the code of the SlotManager more clear.
-- Best, Matt Wang ---- Replied Message ---- | From | David Morávek<d...@apache.org> | | Date | 02/27/2023 22:45 | | To | <dev@flink.apache.org> | | Subject | Re: [DISCUSS] FLIP-298: Unifying the Implementation of SlotManager | Hi Weihua, I still need to dig into the details, but the overall sentiment of this change sounds reasonable. Best, D. On Mon, Feb 27, 2023 at 2:26 PM Zhanghao Chen <zhanghao.c...@outlook.com> wrote: Thanks for driving this topic. I think this FLIP could help clean up the codebase to make it easier to maintain. +1 on it. Best, Zhanghao Chen ________________________________ From: Weihua Hu <huweihua....@gmail.com> Sent: Monday, February 27, 2023 20:40 To: dev <dev@flink.apache.org> Subject: [DISCUSS] FLIP-298: Unifying the Implementation of SlotManager Hi everyone, I would like to begin a discussion on FLIP-298: Unifying the Implementation of SlotManager[1]. There are currently two types of SlotManager in Flink: DeclarativeSlotManager and FineGrainedSlotManager. FineGrainedSlotManager should behave as DeclarativeSlotManager if the user does not configure the slot request profile. Therefore, this FLIP aims to unify the implementation of SlotManager in order to reduce maintenance costs. Looking forward to hearing from you. [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-298%3A+Unifying+the+Implementation+of+SlotManager Best, Weihua
