Hongshun Wang created FLINK-31208:
-------------------------------------

             Summary: KafkaSourceReader overrides meaninglessly a 
method(pauseOrResumeSplits)
                 Key: FLINK-31208
                 URL: https://issues.apache.org/jira/browse/FLINK-31208
             Project: Flink
          Issue Type: Improvement
          Components: Connectors / Kafka
            Reporter: Hongshun Wang


KafkaSourceReader overrides meaninglessly a method(pauseOrResumeSplits) 
,because no difference with its Parent class (SourceReaderBase). why not remove 
this override method?

 

Relative code is here, which we can see is no difference?
{code:java}
//org.apache.flink.connector.kafka.source.reader.KafkaSourceReader#pauseOrResumeSplits
@Override
public void pauseOrResumeSplits(
        Collection<String> splitsToPause, Collection<String> splitsToResume) {
    splitFetcherManager.pauseOrResumeSplits(splitsToPause, splitsToResume);
} 

//org.apache.flink.connector.base.source.reader.SourceReaderBase#pauseOrResumeSplits
@Override
public void pauseOrResumeSplits(
        Collection<String> splitsToPause, Collection<String> splitsToResume) {
    splitFetcherManager.pauseOrResumeSplits(splitsToPause, splitsToResume);
}{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to