Hi Dong,
Thanks for driving this effort! This FLIP LGTM overall. I have just a few
minor comments regarding the proposed API:
1) For the method `DataFrame.collect()`, why is it named `collect` instead
of something else, e.g. `get`? Does it mean that the result will be
computed during this method call?
2) For the method `DataFrame.addColumn`, when will this method be used?
3) In the example `runOnlineInferenceOnWebServer`, it uses
`output_df.getDataType("output")` to get the result type. It's not quite
intuitive. Does it make sense to add a method `getDataType()` in DataFrame?
Regards,
Dian
On Tue, Feb 7, 2023 at 12:37 PM Dong Lin <lindon...@gmail.com> wrote:
> Hi all,
>
> If there is no question related to this FLIP, we will start the voting
> thread on 2/10.
>
> Regards,
> Dong
>
> On Wed, Feb 1, 2023 at 8:38 PM Dong Lin <lindon...@gmail.com> wrote:
>
> > Hi all,
> >
> > Fan, Jiang, Zhipeng, and I have created FLIP-289: Support online
> inference
> > (Flink ML).
> >
> > The goal of this FLIP is to enable users to use the model trained by
> Flink
> > ML to do online inference. More details can be found in the FLIP doc at
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240881268
> > .
> >
> > We are looking forward to your comments.
> >
> > Regards,
> > Dong
> >
>
