Hi Martijn, I was working on FLINK-30623[1], it has been merged today. And the performance of Unaligned checkpoint[2][3] has been recovered.
[1] https://issues.apache.org/jira/browse/FLINK-30623 [2] http://codespeed.dak8s.net:8000/timeline/#/?exe=1&ben=checkpointSingleInput.UNALIGNED&extr=on&quarts=on&equid=off&env=2&revs=200 [3] http://codespeed.dak8s.net:8000/timeline/#/?exe=1&ben=checkpointSingleInput.UNALIGNED_1&extr=on&quarts=on&equid=off&env=2&revs=200 Best Rui Fan On Thu, Jan 26, 2023 at 8:57 PM Martijn Visser <martijnvis...@apache.org> wrote: > Hi Lijie, > > > In summary, I would prefer to extend the "revert regression commits" to > 31st. > > Sounds good to me. > > Thanks, > > Martijn > > Op do 26 jan. 2023 om 12:48 schreef Lijie Wang <wangdachui9...@gmail.com>: > > > Hi Martijn, > > > > Thanks for your detailed explanation. Honestly, the FLINK-30624 is > unlikely > > to be completed before the 26th, but it 's likely to be completed before > > the 31st. Considering that there will be a period of time between feature > > freeze and release, I think we have enough time to see if it is actually > > fixed. > > > > In summary, I would prefer to extend the "revert regression commits" to > > 31st. > > > > Best, > > Lijie > > > > Martijn Visser <martijnvis...@apache.org> 于2023年1月26日周四 16:22写道： > > > > > Hi Lijie, > > > > > > You're right, that's not clearly phrased. Ideally we would like to get > it > > > fixed before the 26th, because that gives us a couple of days to > monitor > > > the benchmarks to see if the regression is actually fixed. If a > > contributor > > > is actively working on a ticket, we could consider delaying the branch > > cut > > > (not the feature freeze) over until the issue is resolved. That is of > > > course except the fix would take something like more than a week after > > the > > > 31st, then it makes more sense to revert the commit that introduced the > > > regression. > > > > > > Let me know what you think. > > > > > > Best regards, > > > > > > Martijn > > > > > > Op do 26 jan. 2023 om 01:11 schreef Lijie Wang < > wangdachui9...@gmail.com > > >: > > > > > > > Hi Martijn, > > > > > > > > I'm working on FLINK-30624, and it may take a while to be resolved. > Do > > > you > > > > mean we should resolve it before the 26th? I used to think the > deadline > > > was > > > > the 31st(the date of feature freeze). > > > > > > > > Best, > > > > Lijie > > > > > > > > Martijn Visser <martijnvis...@apache.org> 于2023年1月25日周三 18:07写道： > > > > > > > > > Hi everyone, > > > > > > > > > > A summary of the release sync of yesterday: > > > > > > > > > > - We still have 3 performance regressions ( > > > > > https://issues.apache.org/jira/browse/FLINK-30623, > > > > > https://issues.apache.org/jira/browse/FLINK-30625, > > > > > https://issues.apache.org/jira/browse/FLINK-30624) that are being > > > worked > > > > > on > > > > > but need to be completed before the release branch cut on the 31st. > > If > > > we > > > > > can't merge PRs to resolve this (at latest on Thursday the 26th) we > > > will > > > > > revert the commits that introduced the regressions. > > > > > - There are 3 release blockers from a test perspective: > > > > > https://issues.apache.org/jira/browse/FLINK-29405, > > > > > https://issues.apache.org/jira/browse/FLINK-30727 and > > > > > https://issues.apache.org/jira/browse/FLINK-29427. Please make > sure > > > that > > > > > if > > > > > you are assigned to this ticket, that you have marked the ticket as > > "In > > > > > Progress". > > > > > - The feature freeze starts on Thursday the 31st of January and the > > > > release > > > > > branch will be cut as soon as the blockers have been resolved. When > > the > > > > > release branch has been cut, the release testing will start. > > > > > > > > > > Best regards, > > > > > > > > > > Qingsheng, Leonard, Matthias and Martijn > > > > > > > > > > > > > > >
